Skip to content

build: remove install hooks from release dist #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haatveit wants to merge 1 commit into
base: master
Choose a base branch
from
Open

build: remove install hooks from release dist #812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ dist: export CGO_ENABLED=0
dist:
rm -rf build/diff/* release/*
mkdir -p build/diff/bin release/
cp README.md LICENSE plugin.yaml build/diff
cp README.md LICENSE build/diff
awk '/^hooks:/ { in_hooks = 1; next } in_hooks && /^[^[:space:]]/ { in_hooks = 0 } !in_hooks { print }' plugin.yaml > build/diff/plugin.yaml
Comment on lines +74 to +75
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change updates the make dist packaging, but the repo's GitHub Releases are currently produced by GoReleaser (see .github/workflows/release.yaml), which still archives plugin.yaml as-is (with hooks) and does not include install-binary.sh. As a result, the published helm-diff-*.tgz artifacts will likely continue to fail helm plugin install the same way (#504). Consider either (a) updating GoReleaser packaging to drop the hooks section for release archives, or (b) adding install-binary.sh to the archived files, or (c) switching the release workflow to run make dist and upload release/*.tgz.

Copilot uses AI. Check for mistakes.
GOOS=linux GOARCH=amd64 $(GO) build -o build/diff/bin/diff -trimpath -ldflags="$(LDFLAGS)"
tar -C build/ -zcvf $(CURDIR)/release/helm-diff-linux-amd64.tgz diff/
GOOS=linux GOARCH=arm64 $(GO) build -o build/diff/bin/diff -trimpath -ldflags="$(LDFLAGS)"
Expand Down
Loading