Release: v2.12.2#1990
Conversation
Keep user-relevant runtime dependency bumps (bcryptjs, markdown-it, shell-quote, @vscode/extension-telemetry); drop dev/CI-only tooling upgrades and e2e test fixes. Strip Jira refs and auto-close trailers.
rugpanov
had a problem deploying
to
test-trigger-is
GitHub Actions
Failure
|
🧪 e2e run for this release (v2.12.2): https://github.com/databricks-eng/eng-dev-ecosystem/actions/runs/28935507838 Triggered via Note: this run lives in an internal repo, so the link is only accessible to Databricks engineers. Results will be summarized here — judged by which specs fail (known-flaky vs regression), not the run-level conclusion. |
|
🔴 Hold — do not merge. The e2e run for this release is 0/34 shards passing on both Linux and Windows (not the usual known-flaky pattern). Root cause is a TypeScript 6 compile break from the TS 5.9.3 → 6.0.3 upgrade (#1981):
Reproduced locally on this branch (TS 6.0.3) — deterministic, a re-run won't clear it. A fix (source/tsconfig) needs to land on |
|
Fix for the TS6 e2e compile break is up: #1991. Once that merges to |
## Why The TypeScript 5.9.3 → 6.0.3 upgrade (#1981) left two test-tooling code paths broken that `yarn build` and unit tests don't exercise. They only run in the e2e workflow (`vscode-isolated-pr`), so the breakage surfaced when cutting the **v2.12.2** release (#1990): **all 34 e2e/SDK shards failed to compile** on both Linux and Windows. ## What broke 1. **`scripts/setArchInPackage.ts` + `scripts/setupCLIDependencies.ts`** still used the pre-TS6 `await yargs.option(...)` pattern. Under TS6, `import yargs from "yargs"` (which uses `export =`) resolves to the callable factory type, not the `Argv` interface, so chaining `.option()` fails with: ``` scripts/setArchInPackage.ts(6,10): error TS2339: Property 'option' does not exist on type '(processArgs?: ...) => Argv<{}>'. ``` `setArchInPackage.ts` runs in the e2e **test-setup** step, which is why every e2e shard died before any spec ran. #1981 already fixed this exact pattern in `writeIpynbWrapper.ts` but missed these two. 2. **`packages/databricks-vscode/tsconfig.json`** got `"types": ["node"]` in #1981, which dropped the mocha ambient globals the SDK integration tests (`src/sdk-extensions/**/*.integ.ts`) rely on: ``` src/sdk-extensions/Cluster.integ.ts: error TS2593: Cannot find name 'describe' / 'it' / 'before'. ``` ## Fix - Call `yargs(process.argv.slice(2))` first in both scripts (same fix #1981 applied to `writeIpynbWrapper.ts`). - Add `"mocha"` to the `types` array (mirrors how `src/test/e2e/tsconfig.json` declares its test-framework types). ## Verification - `yarn run build` — 0 errors - `tsc --noEmit --project tsconfig.json` — 0 errors - `ts-node ./scripts/setArchInPackage.ts …` — runs (was exit 1) - `Cluster.integ.ts` — `describe`/`it`/`before` resolve - `yarn fix` — clean ## Follow-up Once merged, the **v2.12.2** release PR (#1990, currently in draft) will be re-cut so its e2e run can actually execute. Tracked in DECO-27584.
|
Merged |
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
rugpanov
had a problem deploying
to
test-trigger-is
GitHub Actions
Failure
|
🧪 e2e re-run against |
|
✅ e2e re-run against |
3 participants
Release: v2.12.2
Patch release — dependency/security maintenance and internal test/tooling upgrades. No user-facing feature changes.
User-relevant changes (bundled runtime dependencies)
Not in the changelog (internal only)
Dev/CI-only tooling upgrades (TypeScript 6, WebdriverIO v9, mocha 11, nyc, @typescript-eslint v8, @vscode/test-electron, fake-timers, glob, mock-require types, eslint-plugin-local-rules), e2e test flakiness fixes, and a CONTRIBUTING.md guide. These do not ship in the VSIX / are invisible to users.
Bundled Databricks CLI version unchanged (1.2.0).
Release tracked in DECO-27584.