Fix flaky Iterator tests by making metadata fetching async-safe#313
Merged
shivam2680 merged 1 commit intomainfrom Dec 2, 2025
Merged
Fix flaky Iterator tests by making metadata fetching async-safe#313shivam2680 merged 1 commit intomainfrom
shivam2680 merged 1 commit intomainfrom
Conversation
e938182 to
7560842
Compare
Addresses race condition where concurrent calls to fetchMetadata() would attempt multiple server requests before the first completed. This caused failures when GetResultSetMetadata was called after result handler was consumed. The fix uses a promise-based locking pattern to ensure only one metadata fetch occurs, with subsequent concurrent calls waiting for the same promise. Also adds unit tests to verify async-safety of metadata fetching. Signed-off-by: Shivam Raj <shivam.raj@databricks.com>
7560842 to
9a7353a
Compare
gopalldb
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The flaky Iterator tests were failing with:
java.lang.IllegalStateException: Should not get result schema on an empty result handler
This occurred due to two related race conditions:
Root Cause 1: Missing Operation Readiness Check
The hasMoreRows() method was attempting to fetch result metadata before the operation finished executing. When tests used maxRows: null (disabling direct results), the operation had no cached
metadata and would try to fetch it while the server-side operation was still running, causing the result handler to be in an invalid state.
Unlike other methods (getSchema(), fetchChunk()), hasMoreRows() did NOT call waitUntilReady() before accessing metadata.
Root Cause 2: Concurrent Metadata Fetches
When multiple concurrent calls to fetchMetadata() occurred before the first completed:
Fix
Added waitUntilReady() call to ensure the operation completes before fetching metadata:
public async hasMoreRows(): Promise {
if (this.closed || this.cancelled) {
return false;
}
}
Implemented promise-based locking using metadataPromise field:
Tests Added