Merged
Conversation
Signed-off-by: Shivam Raj <shivam.raj@databricks.com>
2f59bac to
47b625a
Compare
vikrantpuppala
approved these changes
Oct 21, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for metric view metadata in the Databricks SQL Node.js driver by introducing a new configuration option that enables retrieval of metric view information through metadata methods. When enabled, the driver injects a Spark configuration parameter during session creation.
Key Changes:
- Added
enableMetricViewMetadataconfiguration option to connection and client interfaces - Modified session opening logic to conditionally inject the Spark configuration parameter
- Added comprehensive test coverage for the new feature
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/contracts/IDBSQLClient.ts | Added enableMetricViewMetadata optional property to ConnectionOptions interface |
| lib/contracts/IClientContext.ts | Added enableMetricViewMetadata optional property to ClientConfig interface |
| lib/DBSQLClient.ts | Stored configuration and injected session parameter when metric view metadata is enabled |
| tests/unit/DBSQLClient.test.ts | Added 6 unit tests covering configuration storage, parameter injection, and user configuration preservation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
gopalldb
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for metric view metadata in the Databricks SQL Node.js driver, following the JDBC driver implementation.
Changes
enableMetricViewMetadataoptional boolean toConnectionOptionsinterfaceenableMetricViewMetadataoptional boolean toClientConfiginterfaceDBSQLClient.connect()to store the configurationDBSQLClient.openSession()to injectspark.sql.thriftserver.metadata.metricview.enabled=truewhen enabledBehavior
When
enableMetricViewMetadata=true:getTables()andgetTableTypes()will include METRIC_VIEW entriesgetColumns()will return measure columns with<data_type> measureformat in TYPE_NAMEUsage
Testing
All 437 unit tests pass including 6 new tests for this feature.
Backward Compatibility
Feature is disabled by default - fully backward compatible.