chore: allowlist Arrow IPC base64 false positives in .gitleaksignore#408
Merged
Conversation
vikrantpuppala
approved these changes
Jul 16, 2026
The Databricks global pre-push secret scanner runs `gitleaks detect` over
each new branch's commit range. The `aws-access-token` rule (which targets
AKIA…/ASIA…-style keys) collides with high-entropy base64 substrings inside
the Apache Arrow IPC payloads stored in the arrowbased testdata fixtures
("batch": "/////..."), producing 24 false positives across 8 files.
These are binary result data, not credentials (entropy ~1.5 vs ~4.3+ for a
real key). All were introduced by f27a47b ("Fetch results in arrow format",
#109), so they re-surface on every new branch whose scan range walks back
through history and re-includes that commit — even for commits that never
touch these files, forcing SKIP_SECRET_SCAN=1 on unrelated pushes.
Committing a repo-root .gitleaksignore (the same fix databricks-driver-test
uses) suppresses them permanently for all branches.
Co-authored-by: Isaac
Signed-off-by: Madhavendra Rathore <madhavendra.rathore@databricks.com>
f14d216 to
3d81412
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Databricks global pre-push secret scanner runs
gitleaks detectover each new branch's commit range. Theaws-access-tokenrule (which targetsAKIA…/ASIA…-style keys) collides with high-entropy base64 substrings inside the Apache Arrow IPC payloads stored in theinternal/rows/arrowbased/testdatafixtures ("batch": "/////5gCAAAU…").This produces 24 false positives across 8 fixture files (
diamonds.json,all_types*.json,arrays_native.json,structs_native.json). They are binary Arrow result data, not credentials — entropy ~1.5 vs ~4.3+ for a real AWS key.All were introduced by
f27a47b("Fetch results in arrow format", #109). Becausegitleaks detectfingerprints are commit-SHA-prefixed and the scan walks back through history, these re-surface on every new branch — even branches that never touch these files — forcing contributors to push withSKIP_SECRET_SCAN=1.Fix
Commit a repo-root
.gitleaksignorelisting the 24 SHA-prefixed fingerprints.gitleaks detectreads this file automatically, so the false positives are suppressed permanently for all branches with no per-push workaround. This mirrors the approach already used indatabricks-driver-test.Verification
Re-running the exact pre-push scan against the introducing commit with the file present:
The push of this branch itself passed the pre-push secret scan with no block.
This pull request and its description were written by Isaac.