-
Notifications
You must be signed in to change notification settings - Fork 63
feat(kernel): SEA-via-kernel backend (opt-in, behind build tag) #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mani-mathur-arch
wants to merge
40
commits into
main
Choose a base branch
from
mani/sea-kernel-backend
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
1f29fd7
feat(kernel): add SEA-via-kernel backend (scalar read path)
mani-mathur-arch 8bc7f17
feat(kernel): render nested and complex types
mani-mathur-arch 20950c9
feat(kernel): map TLS, proxy, and session-conf connection options
mani-mathur-arch 0c11201
fix(kernel): honor session timezone; reject unsupported options; fix …
mani-mathur-arch 031c783
fix(kernel): render nested decimals as exact JSON numbers
mani-mathur-arch 8c99345
fix(kernel): sync to merged kernel C ABI (cancel arity, logging, doub…
mani-mathur-arch d87f614
Merge remote-tracking branch 'origin/main' into mani/sea-kernel-backend
mani-mathur-arch 45aaf84
fix(kernel): map InsecureSkipVerify to both kernel TLS relaxations
mani-mathur-arch 220d0d2
chore(kernel): remove hardcoded local kernel paths from cgo directives
mani-mathur-arch c7a19f0
fix(kernel): address code review — correctness, doc-contract, parity,…
mani-mathur-arch 5852480
ci(kernel): document deferral of the tagged kernel-path test job (H5)
mani-mathur-arch a0d1b47
ci(kernel): trim the kernel-path CI deferral comment
mani-mathur-arch 37196b9
docs(kernel): round-2 review — doc/comment/test-helper cleanups
mani-mathur-arch 7d063b2
fix(kernel): round-2 review — float32 parity + close() contract
mani-mathur-arch 0a4ab9b
docs(kernel): round-2 review — correct cancellation + telemetry docs
mani-mathur-arch 490c97d
test(kernel): strengthen proxy test via a resolver seam (N7)
mani-mathur-arch d7263ea
fix(kernel): remove struct-key prefix cache — unbounded memory leak (N1)
mani-mathur-arch 13a997f
refactor(kernel): extract Arrow cell/JSON rendering to untagged arrow…
mani-mathur-arch 44e180f
fix(arrowscan): suppress G115 on the defensive Uint64 arm
mani-mathur-arch 0955e00
fix(kernel): surface server queryId in kernel error log and message (M5)
mani-mathur-arch 9a5f62d
fix(kernel): close fail-loud contract holes for auth/timeout/retries …
mani-mathur-arch d272157
refactor(kernel): move proxy resolution to an untagged file so its te…
mani-mathur-arch bf3b2f1
fix(arrowbased): JSON-escape struct field-name keys + guard cross-bac…
mani-mathur-arch f90c230
docs(kernel): round-4 review — doc caveats + Thrift grammar back-pointer
mani-mathur-arch 04e12c5
perf(arrowbased): precompute escaped struct keys once, not per row (M1)
mani-mathur-arch 4707b32
fix(arrowscan): render map keys like Thrift (base64 []byte, not fmt %…
mani-mathur-arch f276304
test(arrowbased): extend cross-backend parity to high-drift nested sh…
mani-mathur-arch 08cbcfe
fix(kernel): never return ErrBadConn on the execute/read path (H1)
mani-mathur-arch b2f3b57
refactor(kernel): untag config validation + guard against dropped Con…
mani-mathur-arch e394848
test(kernel): flatten embedded structs in the config drop-guard (M2-r…
mani-mathur-arch 8c730da
fix(kernel): evict a dead session on the statement path; stop retryin…
mani-mathur-arch 5068f5a
perf(arrowscan): memoize struct-key escaping per result set on the ke…
mani-mathur-arch 0eaf600
test(arrowbased): add top-level scalar parity + document the DECIMAL …
mani-mathur-arch d6a3cf4
cleanup(arrowbased): remove dead fieldNames + strengthen the decimal …
mani-mathur-arch 3a01ead
fix(kernel): round-6 review — int parity, port/protocol reject, untag…
mani-mathur-arch feb8b2b
docs(kernel): drop internal review-note labels from comments
mani-mathur-arch cbcd20a
fix(kernel): address review — staging reject, drift guard, typed reje…
mani-mathur-arch 0a14eeb
fix(kernel): address review round 2 — nested-offset correctness + log…
mani-mathur-arch cd3b1c5
docs(kernel): mark deferred follow-ups inline so reviewers see them
mani-mathur-arch b895793
fix(kernel): address review round 7 — contract, proxy, cache, message…
mani-mathur-arch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow comment itself states a
CGO_ENABLED=1 -tags databricks_kerneljob "needs" to be added — confirming no such job exists. All tagged files (backend.go,cgo.go,operation.go,rows.go) compile/run only under the tag, and the only tests touching them are e2e/parity tests that both carry the tag andt.Skipwithout live creds. So the cancel-watcher goroutine, per-batch release/EOF handling, andclose()idempotency never execute in any pipeline. A deadlock/leak/double-free ships green.CGO_ENABLED=1 -tags databricks_kerneljob (build-only + a stubbed C ABI for the watcher/close logic) so lifecycle code is exercised without a live warehouse. Track the acknowledged follow-up explicitly.Posted by code-review-squad ·
/full-review· feedback:#code-review-squad-feedback