[PECOBLR-3982] Use JDBC-standard exception for unimplemented features - #1650
Draft
prathamesh-db wants to merge 1 commit into
Draft
[PECOBLR-3982] Use JDBC-standard exception for unimplemented features#1650prathamesh-db wants to merge 1 commit into
prathamesh-db wants to merge 1 commit into
Conversation
Signed-off-by: Prathamesh Baviskar <prathamesh.baviskar@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brickyard’s driver-error alert for 3.0.1 surfaced a large volume of unsupported-operation failures. Transactions and callable statements were implemented in later driver releases, but the current driver still reports genuinely unsupported JDBC methods through an exception that does not implement the standard
SQLFeatureNotSupportedExceptioncontract.This change makes
DatabricksSQLFeatureNotImplementedExceptionextendSQLFeatureNotSupportedExceptionwhile preserving the existingNOT_IMPLEMENTED_OPERATIONtelemetry export and vendor code0.Testing
The new focused test verifies the JDBC exception type, SQL state, vendor code, and telemetry export. All 46
DatabricksConnectionTestcases pass, and Spotless passes.Telemetry Errors
DatabricksDriverErrorCodewhere appropriate, and any new code is uniquely numbered and tested.NOT_IMPLEMENTED_OPERATIONclassification remains driver-owned.Additional Notes to the Reviewer
This reuses the existing error enum; no new telemetry code is added.
Compatibility tradeoff: code that catches only
DatabricksSQLExceptionwill no longer catch this exception. Code catchingSQLException,SQLFeatureNotSupportedException, or the concrete exception continues to work. Please review whether adopting the JDBC-standard hierarchy justifies that source-level behavior change.Jira: PECOBLR-3982