Fix Arrow chunk download telemetry error bucketing - #1649
Open
prathamesh-db wants to merge 1 commit into
Open
Conversation
Signed-off-by: Prathamesh Baviskar <prathamesh.baviskar@databricks.com>
prathamesh-db
marked this pull request as ready for review
August 21, 2026 05:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An internal telemetry investigation found Arrow chunk download failures being emitted as
DOWNLOAD_FAILED, which is an internal lifecycle state rather than a stable driver error code.This change emits the existing
CHUNK_DOWNLOAD_ERRORcode for genuine download failures and preserves processing failures instead of relabeling them as download failures. It improves telemetry bucketing; it does not change download or retry behavior.Testing
ArrowResultChunkStatusTestpasses all 3 cases, covering the successful flow, a body-read failure emittingCHUNK_DOWNLOAD_ERROR, and malformed Arrow data remainingPROCESSING_FAILED. The repository-wide Spotless check also passes.Telemetry Errors
DatabricksDriverErrorCodewhere appropriate, and anynew code is uniquely numbered and tested.
CHUNK_DOWNLOAD_ERRORclassification remains driver-owned.Additional Notes to the Reviewer
This intentionally reuses
CHUNK_DOWNLOAD_ERROR; no new error enum is needed.