[2/7] Add native batching configuration and parameter model - #1621
[2/7] Add native batching configuration and parameter model#1621sreekanth-db wants to merge 3 commits into
Conversation
Keep existing batching behavior behind a dedicated executor so native routing can be added without changing the compatibility fallback. Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
Introduce a dormant opt-in and deterministic parameter snapshots so both native transports can share the same ordered payload without changing execution behavior. Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
![peco-review-bot[bot]](https://avatars.githubusercontent.com/in/3801177?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verdict: 1 Low
Looks good — clean, well-tested dormant foundation (config flag + immutable ordered parameter-set model with defensive value snapshotting). One low-severity note: the model uses zero-based wire ordinals while the current SEA path is one-based, worth verifying before the execution path is wired up.
Scope: reviewed as a stacked increment (520eb7f..head); the parent's changes are reviewed on the parent PR.
|
JDBC integration tests triggered ( |
sreekanth-db
changed the title
gopalldb
left a comment
gopalldb
left a comment
There was a problem hiding this comment.
nit: Adding new property without being used
|
Integration test approval reset. New commits were pushed to this PR. Label(s) A maintainer must re-review and re-add a label to preview tests again. (The real gate runs in the merge queue.) Latest commit: 632708e |
2 participants
🥞 Stacked PR
Use this link to review incremental changes.
Description
Add the dormant foundation for native parameter batching.
EnableNativeBatching, disabled by default.This PR does not change batch execution or send native requests.
Testing
jdbc-coresuite: 3,611 passed, 88 skipped.Additional Notes to the Reviewer
No telemetry field is included because that requires the corresponding backend telemetry proto change.
NO_CHANGELOG=true