-
Notifications
You must be signed in to change notification settings - Fork 215
Bump default serverless environment version to 5 #6378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
af3f027
5b1d7b1
3f41ff3
d8c43f5
989250c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Bundle templates are upgraded from serverless environment version 4 to [version 5](https://docs.databricks.com/aws/en/release-notes/serverless/environment-version/five) for generated serverless jobs and notebooks (`default-python`, `default-scala`, `dbt-sql`, `pydabs`, and `lakeflow-pipelines`). The Python templates now pin `databricks-connect>=18.0,<18.1` and Python `>=3.12,<3.13` (previously `databricks-connect>=15.4,<15.5` and Python `>=3.10,<3.13`) to match environment version 5's DB Connect 18 and Python 3.12 runtime. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,4 +29,4 @@ resources: | |
| environments: | ||
| - environment_key: default | ||
| spec: | ||
| environment_version: "4" | ||
| environment_version: "5" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,4 +29,4 @@ resources: | |
| environments: | ||
| - environment_key: default | ||
| spec: | ||
| environment_version: "4" | ||
| environment_version: "5" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,4 +29,4 @@ resources: | |
| environments: | ||
| - environment_key: default | ||
| spec: | ||
| environment_version: "4" | ||
| environment_version: "5" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,4 +29,4 @@ resources: | |
| environments: | ||
| - environment_key: default | ||
| spec: | ||
| environment_version: "4" | ||
| environment_version: "5" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,4 +29,4 @@ resources: | |
| environments: | ||
| - environment_key: default | ||
| spec: | ||
| environment_version: "4" | ||
| environment_version: "5" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,40 +5,39 @@ | |
| 16.4.x-scala2.12 | ||
| {{- end}} | ||
|
|
||
| {{/* A safe version of DB Connect that is compatible with at least half the | ||
| * clusters running in production. | ||
| {{/* The DB Connect version for local development, matched to the serverless | ||
| * environment version selected above. | ||
| * | ||
| * We need to be very conservative in updating this, since a newer version can | ||
| * only connect to compute of that same version and higher. If the version is | ||
| * deemed too old, customers can update the version themselves after initializing | ||
| * the template. | ||
| * Environment version 5 ships DB Connect 18 (Python 3.12), so we pin to 18.0.x. | ||
| * DB Connect is forward-compatible (a client connects to compute of the same | ||
| * version and higher), so a client newer than the environment's version would | ||
| * not connect; matching the environment version keeps local development | ||
| * client-server compatible with the serverless runtime. Customers can change | ||
| * this after initializing the template. | ||
| * | ||
| * See https://docs.databricks.com/dev-tools/databricks-connect/python/index.html#requirements | ||
| * for DB Connect release notes and version compatibility. | ||
| */}} | ||
| {{define "conservative_db_connect_version_spec" -}} | ||
| >=15.4,<15.5 | ||
| >=18.0,<18.1 | ||
| {{- end}} | ||
|
|
||
| {{/* The serverless environment version to use. | ||
| * See https://docs.databricks.com/release-notes/runtime/index.html for available versions. | ||
| */}} | ||
| {{define "serverless_environment_version" -}} | ||
| 4 | ||
| 5 | ||
| {{- end}} | ||
|
|
||
| {{/* Python version specification for the template. | ||
| * This needs to be compatible with the version of DB Connect and the serverless_environment_version. | ||
| * | ||
| * Serverless environment version 4 (and upcoming v5), DBR 16, and DBR 17 all use Python 3.12. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please also still mention 4 here (for maintainers)
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done — the comment now reads "Serverless environment versions 4 and 5, DBR 16, and DBR 17 all use Python 3.12." |
||
| * DB Connect 15 supports all of these and is compatible with Python 3.10-3.12. | ||
| * | ||
| * We use >=3.10,<3.13 rather than pinning to 3.12 specifically because overly narrow pinning | ||
| * means users always need to use uv or similar tools to install the exact version. A broader | ||
| * range improves usability while maintaining compatibility with both DB Connect and serverless. | ||
| * Serverless environment versions 4 and 5, DBR 16, and DBR 17 all use Python 3.12. | ||
| * DB Connect 16.4 requires Python 3.12, so we pin the project to 3.12 to match both | ||
| * DB Connect and the serverless runtime. | ||
| */}} | ||
| {{define "python_version_spec" -}} | ||
| >=3.10,<3.13 | ||
| >=3.12,<3.13 | ||
| {{- end}} | ||
|
|
||
| {{/* The default Python version used in notebook metadata. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[question]
environment_version 5 actually requires datbaricks-connect>=18.0 to work now.
Is updating the db-connect version for the Python version compatibility rather than the db-connect client <> server compatibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point — bumped to
>=18.0,<18.1to match v5's DB Connect 18 (client↔server compat). Verified:uv syncresolvesdatabricks-connect==18.0.9, v5's shipped version. 18.0 is also Python 3.12, so the Python pin is unchanged.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rugpanov
Bumping the db-connect version from 15 to 18 seems aggressive. I heard from @lennartkats-db that the db-connect version should only be bumped up when it reaches LTS. Can you please help confirm with @lennartkats-db that this upgrade is good?