Open
Conversation
Approval is now enforced through the maintainer-approval GitHub Action (required status check) and the OWNERS file, rather than GitHub's built-in CODEOWNERS mechanism. This gives us more flexible per-path approval logic while keeping the same ownership rules. Co-authored-by: Isaac
simonfaltum
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: @andrewnester, @anton-107, @denik, @pietern, @shreyas-goenka Suggestions based on git history. See OWNERS for ownership rules. |
simonfaltum
removed request for
andrewnester,
anton-107,
denik and
shreyas-goenka
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Approval enforcement is now handled by the
maintainer-approvalGitHub Action (a required status check) and the.github/OWNERSfile. GitHub's built-in CODEOWNERS mechanism is no longer needed and creates redundancy.Changes
Removes
.github/CODEOWNERS. The.github/OWNERSfile already contains the same ownership rules (and more), and the maintainer-approval workflow reads from OWNERS.Test plan
maintainer-approvalis now a required status check on main