pipelines: fix auto-selection in "pipelines run" #4245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanterov
requested review from
jefferycheng1 and
lennartkats-db
as code owners
kanterov
changed the title
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
| // Returns empty string if there's not exactly one pipeline. | ||
| func autoSelectSinglePipeline(b *bundle.Bundle) string { | ||
| completions := resources.Completions(b, run.IsRunnable) | ||
| completions := resources.Completions(b, isPipeline) |
Collaborator
There was a problem hiding this comment.
just a drive by comment since I got tagged: this was an intentional decision at the time from some one-off discussion. I think the product decision at the time was to still to expose anything that can still be run. Just curious if we've changed this decision.
Collaborator
Author
There was a problem hiding this comment.
Our template includes a job and a pipeline, so "run" command doesn't work because there are 2 runnable resources. Given that we are exposing the same "run" command in "databricks pipelines run", it should behave differently from "databricks bundles run", similar to how "databricks app run" and "databricks jobs run" should filter by their resource type.
Collaborator
|
Commit: 6af4dad
41 interesting tests: 13 KNOWN, 13 FAIL, 12 RECOVERED, 2 MISS, 1 SKIP
Top 26 slowest tests (at least 2 minutes):
|
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
lennartkats-db
approved these changes
Jan 12, 2026
Contributor
lennartkats-db
left a comment
lennartkats-db
left a comment
There was a problem hiding this comment.
👍 I'm fine with this refinement, thanks Gleb!
| Deploying resources... | ||
| Updating deployment state... | ||
| Deployment complete! | ||
| View your job my_job here: [DATABRICKS_URL]/jobs/[NUMID]?o=[NUMID] |
Contributor
There was a problem hiding this comment.
Non-blocking: I don't think we should show all URLs for many-resource DABs projects. We still don't have a good "single" URL for deployments yet. The alternative I think we discussed way back was to show a hint to use the summary command whenever there is >1 resource. But 1 pipeline + 1 job could also be treated as a special case.
Collaborator
Author
There was a problem hiding this comment.
Makes sense. Do I understand correctly, that this suggestion applies generically to DABs, and not special to pipelines?
Collaborator
|
Commit: 3d63763
31 interesting tests: 17 KNOWN, 8 RECOVERED, 3 BUG, 2 FAIL, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix auto-selection in "pipelines run" command.
Previously, if bundle had a job and a pipeline, auto-selection didn't work because both are considered runnable. This is true, for example, for lakeflow-pipelines template. It's not intended because "pipelines run" command should only be applicable to pipelines.
Why
Fixing not correct behaviour
Tests
Acceptance tests