Conversation
kanterov
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
reviewed
Apr 22, 2025
.codegen.json
Outdated
| "echo 'go.sum linguist-generated=true' >> ./.gitattributes", | ||
| "echo 'bundle/schema/jsonschema.json linguist-generated=true' >> ./.gitattributes" | ||
| "echo 'bundle/schema/jsonschema.json linguist-generated=true' >> ./.gitattributes", | ||
| "pushd experimental/python && uv lock" |
Contributor
There was a problem hiding this comment.
I don't think this is run as part of the tagging workflow, only as part of the generation workflow.
@andrewnester Can you confirm?
kanterov
force-pushed
the
update-uv-lock
branch
from
82aa2e0 to
5738f77
Compare
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
Author
|
I changed the approach to use the existing substitution mechanism that apparently supports newlines (source: https://github.com/databricks/databricks-sdk-java/blob/main/.codegen.json) |
denik
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Update
uv.lockduring tagging and fixuv.lockbroken during the previous release.Previously, we used the genkit version substitution mechanism, which didn't work because it replaced all versions in the UV lock file, and we reverted it in #2731
Why
Having an outdated
uv.lockbreaks Python builds after release.Tests
Not tested