Conversation
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
force-pushed
the
python-support-pipelines
branch
from
82f8d25 to
905203f
Compare
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
force-pushed
the
python-support-pipelines
branch
from
905203f to
095303d
Compare
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
kanterov
force-pushed
the
python-support-pipelines
branch
from
095303d to
30d961b
Compare
kanterov
force-pushed
the
python-support-pipelines
branch
from
30d961b to
ba9648a
Compare
kanterov
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
denik
reviewed
Apr 4, 2025
| name: VariableOrOptional[str] | ||
| """ | ||
| TODO | ||
| """ |
Contributor
There was a problem hiding this comment.
what is this TODO for? can we drop this completely?
Collaborator
Author
There was a problem hiding this comment.
The pipeline class doesn't have any fields except name, which is only used as an example. There is a separate PR to add remaining fields.
Contributor
There was a problem hiding this comment.
Can you link this to this PR (or the follow-up if ready)?
Collaborator
Author
There was a problem hiding this comment.
👍 , linked
PR with generated code: #2639
experimental/python/databricks/bundles/pipelines/_models/pipeline.py
Outdated
Show resolved
Hide resolved
pietern
reviewed
Apr 7, 2025
| name: VariableOrOptional[str] | ||
| """ | ||
| TODO | ||
| """ |
Contributor
There was a problem hiding this comment.
Can you link this to this PR (or the follow-up if ready)?
kanterov
force-pushed
the
python-support-pipelines
branch
from
ba9648a to
dfc8de5
Compare
Collaborator
Author
|
@pietern addressed comments, please take a look again |
kanterov
added a commit
that referenced
this pull request
Apr 8, 2025
## Changes Add support for pipelines into `experimental/python`. Only the `name` property is supported, and the generated code will be added as a follow-up. ## Why It allows using pipelines in addition to jobs. ## Tests Unit and acceptance tests --------- Co-authored-by: Pieter Noordhuis <pieter.noordhuis@databricks.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 9, 2025
## Changes Add generated code for pipelines support introduced in #2574
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add support for pipelines into
experimental/python.Only the
nameproperty is supported, and the generated code will be added as a follow-up.Why
It allows using pipelines in addition to jobs.
Tests
Unit and acceptance tests