Conversation
kanterov
force-pushed
the
kanterov/python-codegen
branch
3 times, most recently
from
20b87ec to
5891b08
Compare
kanterov
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
There was a problem hiding this comment.
The file is called openapi.py, but it looks like this exclusively depends on the JSON schema.
Is that correct?
There was a problem hiding this comment.
Initially, it was implementing OpenAPI until we introduced JSON schema into CLI, let me rename it.
experimental/python/codegen/codegen/generated_dataclass_patch.py
Outdated
Show resolved
Hide resolved
kanterov
force-pushed
the
kanterov/python-codegen
branch
from
5891b08 to
977df62
Compare
|
@pietern addressed your comments, please take a look again |
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
Please TAL at the comments.
| # | ||
| # We can't load all types because of errors while loading some of them. | ||
| LOADED_NAMESPACES = [ | ||
| "compute", |
There was a problem hiding this comment.
The compute namespace is for job clusters, right?
There was a problem hiding this comment.
It's for job clusters and pipeline cluster configuration
|
|
||
| # TODO block PR if this fails once diffs are fixed | ||
| # exit 1 | ||
| fi |
There was a problem hiding this comment.
Are the tests run on push?
There was a problem hiding this comment.
There is a little bit of a problem, if codegen itself crashed CI job will pass now, let me fix it
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
|
@kanterov Is this ready? |
2 participants
Changes
Add the code generator from the bundle schema to the Python code. Currently, it's only enabled for the "jobs" package.
There is a new GitHub action to verify that codegen is always up-to-date whenever we update bundle schema.
Depends on #2508
Tests