refactor: move generated types into appkit-types/ directory#267
Open
refactor: move generated types into appkit-types/ directory#267
Conversation
pkosiec
force-pushed
the
pkosiec/improve-gen-types
branch
from
0b90870 to
d93dbfb
Compare
Consolidate generated .d.ts files into a single src/appkit-types/ directory instead of polluting client/src/ with multiple top-level type files. TypeScript auto-discovers files via "include": ["src"]. - analytics types: src/appkit-types/analytics.d.ts - serving types: src/appkit-types/serving.d.ts Both generators now ensure the parent directory exists before writing. Directory name and filenames are shared constants in type-generator. Signed-off-by: Pawel Kosiec <pawel.kosiec@databricks.com>
pkosiec
force-pushed
the
pkosiec/improve-gen-types
branch
from
d93dbfb to
190f62c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated type declaration files (analytics query types, serving endpoint types) used to live as separate top-level files in
client/src/. This PR moves them into a dedicatedsrc/appkit-types/directory — one file per plugin. TypeScript auto-discovers them via"include": ["src"]in tsconfig, so no index or barrel file is needed.Screenshots
Changes
src/appKitTypes.d.ts→src/appkit-types/analytics.d.tssrc/appKitServingTypes.d.ts→src/appkit-types/serving.d.tsmkdir -pbefore writing, so the directory is created on first runTYPES_DIR,ANALYTICS_TYPES_FILE,SERVING_TYPES_FILE).gitignore