Fix: run npm via shell in start_app.py so it works on Windows#225
Open
noramxiao wants to merge 2 commits into
Open
Fix: run npm via shell in start_app.py so it works on Windows#225noramxiao wants to merge 2 commits into
noramxiao wants to merge 2 commits into
Conversation
start_app.py invoked `subprocess.run(cmd.split(), ...)` for `npm install` and `npm run build`. On Windows npm is a `.cmd` shim that CreateProcess cannot execute directly, so a split argv raised FileNotFoundError. Pass the command string with shell=True so it resolves through the platform shell on Windows, macOS, and Linux. Edited the synced source (.scripts/source/start_app.py) and propagated to all templates via `python .scripts/sync-scripts.py`. Fixes #126 Co-authored-by: Isaac
Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows,
uv run start-appfails withFileNotFoundErrorduring frontend setup.start_app.pyruns the npm commands as:npmon Windows is a.cmdshim thatCreateProcesscan't execute directly, so passing a split argv (["npm", "install"]) raisesFileNotFoundError. Reported in #126.Change
Passing the command string with
shell=Trueresolves the executable through the platform shell on Windows (cmd.exe), macOS, and Linux (/bin/sh -c), so the same code works everywhere. This matches the fix suggested by the reporter.Fixes #126