Fetch APX skills from upstream repo instead of bundling locally#217
Open
calreynolds wants to merge 1 commit intomainfrom
Open
Fetch APX skills from upstream repo instead of bundling locally#217calreynolds wants to merge 1 commit intomainfrom
calreynolds wants to merge 1 commit intomainfrom
Conversation
APX skills are now dynamically fetched from github.com/databricks-solutions/apx at install time, matching the pattern used for MLflow skills. File discovery uses the GitHub Contents API so new files added by the APX team are automatically picked up without changes here. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
renardeinside
requested changes
Mar 5, 2026
Collaborator
renardeinside
left a comment
renardeinside
left a comment
There was a problem hiding this comment.
a couple of things off
| done | ||
| [ -f "$dest_dir/SKILL.md" ] || rm -rf "$dest_dir" | ||
| else | ||
| rm -rf "$dest_dir" |
Collaborator
There was a problem hiding this comment.
this line seems like a potential security hole - can we improve it?
Comment on lines
85
to
+739
| @@ -727,6 +732,24 @@ install_skills() { | |||
| fi | |||
| done | |||
| ok "MLflow skills → ${dir#$HOME/}" | |||
|
|
|||
| # Install APX skills from databricks-solutions/apx repo | |||
| for skill in $APX_SKILLS; do | |||
| local dest_dir="$dir/$skill" | |||
| mkdir -p "$dest_dir" | |||
Collaborator
There was a problem hiding this comment.
can we test this somehow? I've tried curling these urls and didn't get any valid response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
databricks-app-apx) are now fetched at install time fromgithub.com/databricks-solutions/apx/skills/apxinstead of being bundled in this repo--apx-versionflag support for version pinningTest plan
install_skills.sh --listshows APX under its own sectioninstall_skills.sh databricks-app-apxfetches all 3 files dynamically from the APX repoinstall_skills.sh --local databricks-app-apxfails with a clear error messageinstall.shrun installs APX skills alongside Databricks and MLflow skills🤖 Generated with Claude Code