BUG: limit the range of elements in test_{eig,eigvals}#427
Merged
ev-br merged 1 commit intodata-apis:masterfrom Mar 17, 2026
Merged
BUG: limit the range of elements in test_{eig,eigvals}#427ev-br merged 1 commit intodata-apis:masterfrom
ev-br merged 1 commit intodata-apis:masterfrom
Conversation
Otherwise torch fails to converge if the matrix is too ill-conditioned. Notice 6.7e+111, 6.9e+128, 7e+90 values in this failing example: ``` > res = linalg.eigvals(x) E torch._C._LinAlgError: torch.linalg.eigvals: (Batch element 1): The algorithm failed to converge because the input matrix is ill-conditioned or has too many repeated eigenvalues (error code: 6). E Falsifying example: test_eigvals( E x=tensor([[[ 0.0000e+00, 2.0000e+00, 2.0000e+00, 2.0000e+00, 2.0000e+00, E 2.0000e+00], E [ 2.0000e+00, 2.0000e+00, 2.0000e+00, 2.0000e+00, 2.0000e+00, E 2.0000e+00], E [ 2.0000e+00, 2.0000e+00, 2.0000e+00, 2.0000e+00, 2.0000e+00, E 2.0000e+00], E [ 2.0000e+00, 2.0000e+00, 2.0000e+00, 2.0000e+00, 2.0000e+00, E 2.0000e+00], E [ 2.0000e+00, 2.0000e+00, 2.0000e+00, 2.0000e+00, 2.0000e+00, E 2.0000e+00], E [ 2.0000e+00, 2.0000e+00, 2.0000e+00, 2.0000e+00, 2.0000e+00, E 2.0000e+00]], E E [[ 2.0000e+00, 2.0000e+00, 2.0000e+00, 2.0000e+00, 2.0000e+00, E 2.0000e+00], E [6.7525e+111, 2.0000e+00, 2.0000e+00, 6.9317e+128, 2.0000e+00, E 2.0000e+00], E [ 2.0000e+00, 2.0000e+00, 2.0000e+00, 2.0000e+00, 2.0000e+00, E 2.0000e+00], E [ 2.0000e+00, 0.0000e+00, 2.0000e+00, 2.0000e+00, 7.5592e+90, E 2.0000e+00], E [ 2.0000e+00, 2.0000e+00, 2.0000e+00, 2.0000e+00, 2.0000e+00, E 2.0000e+00], E [ 2.0000e+00, 2.0000e+00, 2.0000e+00, 2.0000e+00, 2.0000e+00, E 2.0000e+00]]], dtype=torch.float64), E ) array_api_tests/test_linalg.py:375: _LinAlgError ```
Member
Author
|
Merging quickly to avoid failures in unrelated PRs, e.g. data-apis/array-api-compat#405 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise torch fails to converge if the matrix is too ill-conditioned. Notice 6.7e+111, 6.9e+128, 7e+90 values in this failing example: