docs: remove stale ML tutorial reference - #250
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ncclementi
left a comment
There was a problem hiding this comment.
Thanks for the PR, just a small suggestion
| "\n", | ||
| "This is a high-level overview demonstrating some the components of Dask-ML.\n", | ||
| "Visit the main [Dask-ML](http://ml.dask.org) documentation, see the [dask tutorial](https://github.com/dask/dask-tutorial) notebook 08, or explore some of the other machine-learning examples." | ||
| "Visit the main [Dask-ML](http://ml.dask.org) documentation or explore some of the other machine-learning examples." |
There was a problem hiding this comment.
Just point to dask ml docs, fix typo
| "Visit the main [Dask-ML](http://ml.dask.org) documentation or explore some of the other machine-learning examples." | |
| "Visit the main [Dask-ML](http://ml.dask.org) documentation to explore some of the other machine-learning examples." |
There was a problem hiding this comment.
Updated in 8b8117f: the sentence now points directly to the Dask-ML docs and includes the typo correction from the suggestion.
Validation: python3 -m json.tool machine-learning.ipynb, git diff --check, and pre-commit run --files machine-learning.ipynb all pass (nbstripout passed). Thanks!
|
Looks like CI is failing, because the action are too old. Your contribution is good, the problem is this will not get deployed. Apologies. I'll leave it open in case a maintainer picks up updating the actions, but this repository hasn't seen work in a while, so I doubt it happens. |
|
Thanks for reviewing and for the context. Understood — I'll leave the patch open as-is in case the repository's actions are revived. |
Fixes #234
Removes the reference to notebook 08 in the Dask tutorial, which no longer contains the linked machine-learning lesson. The overview now directs readers to the Dask-ML documentation and the repository's other machine-learning examples.
Tests:
pre-commit run --files machine-learning.ipynbjq empty machine-learning.ipynbgit diff --check