Skip to content

docs: remove stale ML tutorial reference - #250

Open
nightcityblade wants to merge 2 commits into
dask:mainfrom
nightcityblade:fix/issue-234
Open

docs: remove stale ML tutorial reference#250
nightcityblade wants to merge 2 commits into
dask:mainfrom
nightcityblade:fix/issue-234

Conversation

@nightcityblade

Copy link
Copy Markdown

Fixes #234

Removes the reference to notebook 08 in the Dask tutorial, which no longer contains the linked machine-learning lesson. The overview now directs readers to the Dask-ML documentation and the repository's other machine-learning examples.

Tests:

  • pre-commit run --files machine-learning.ipynb
  • jq empty machine-learning.ipynb
  • git diff --check

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ncclementi ncclementi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, just a small suggestion

Comment thread machine-learning.ipynb Outdated
"\n",
"This is a high-level overview demonstrating some the components of Dask-ML.\n",
"Visit the main [Dask-ML](http://ml.dask.org) documentation, see the [dask tutorial](https://github.com/dask/dask-tutorial) notebook 08, or explore some of the other machine-learning examples."
"Visit the main [Dask-ML](http://ml.dask.org) documentation or explore some of the other machine-learning examples."

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just point to dask ml docs, fix typo

Suggested change
"Visit the main [Dask-ML](http://ml.dask.org) documentation or explore some of the other machine-learning examples."
"Visit the main [Dask-ML](http://ml.dask.org) documentation to explore some of the other machine-learning examples."

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 8b8117f: the sentence now points directly to the Dask-ML docs and includes the typo correction from the suggestion.

Validation: python3 -m json.tool machine-learning.ipynb, git diff --check, and pre-commit run --files machine-learning.ipynb all pass (nbstripout passed). Thanks!

@ncclementi

Copy link
Copy Markdown
Member

Looks like CI is failing, because the action are too old. Your contribution is good, the problem is this will not get deployed.
There are currently no efforts in maintaining this repository. So the changes won't be reflected.

Apologies. I'll leave it open in case a maintainer picks up updating the actions, but this repository hasn't seen work in a while, so I doubt it happens.

@nightcityblade

Copy link
Copy Markdown
Author

Thanks for reviewing and for the context. Understood — I'll leave the patch open as-is in case the repository's actions are revived.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ML notebook points to ML tutorial lesson that was removed

2 participants