Skip to content

feat(key-wallet): add chainlock handling to the wallet #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZocoLini merged 2 commits into from
May 12, 2026

fix(dash-spv): re-run `verify_block_hash` before promoting a deferred…

d643d8e
Select commit
Loading
Failed to load commit list.
Merged

feat(key-wallet): add chainlock handling to the wallet #756

fix(dash-spv): re-run `verify_block_hash` before promoting a deferred…
d643d8e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 12, 2026 in 0s

72.25% (+0.00%) compared to 78cf339

View this Pull Request on Codecov

72.25% (+0.00%) compared to 78cf339

Details

Codecov Report

❌ Patch coverage is 66.78700% with 92 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.25%. Comparing base (78cf339) to head (d643d8e).
⚠️ Report is 3 commits behind head on v0.42-dev.

Files with missing lines Patch % Lines
dash-spv-ffi/src/callbacks.rs 15.90% 37 Missing ⚠️
dash-spv-ffi/src/bin/ffi_cli.rs 0.00% 19 Missing ⚠️
dash-spv/src/client/event_handler.rs 74.46% 12 Missing ⚠️
key-wallet-manager/src/events.rs 0.00% 8 Missing ⚠️
dash-spv/src/client/sync_coordinator.rs 66.66% 6 Missing ⚠️
...allet/managed_wallet_info/wallet_info_interface.rs 82.85% 6 Missing ⚠️
dash-spv/src/sync/chainlock/manager.rs 93.33% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           v0.42-dev     #756    +/-   ##
===========================================
  Coverage      72.25%   72.25%            
===========================================
  Files            320      320            
  Lines          69651    70275   +624     
===========================================
+ Hits           50326    50780   +454     
- Misses         19325    19495   +170
Files with missing lines Coverage Δ
dash-spv/src/sync/chainlock/sync_manager.rs 87.09% <100.00%> (ø)
key-wallet-manager/src/process_block.rs 92.83% <100.00%> (+0.35%) ⬆️
key-wallet-manager/src/wallet_interface.rs 15.00% <ø> (ø)
.../src/managed_account/managed_core_funds_account.rs 76.72% <100.00%> (+0.24%) ⬆️
...t/src/managed_account/managed_core_keys_account.rs 57.71% <100.00%> (+5.80%) ⬆️
dash-spv/src/sync/chainlock/manager.rs 93.25% <93.33%> (-0.04%) ⬇️
dash-spv/src/client/sync_coordinator.rs 76.34% <66.66%> (-1.58%) ⬇️
...allet/managed_wallet_info/wallet_info_interface.rs 83.15% <82.85%> (-0.07%) ⬇️
key-wallet-manager/src/events.rs 67.47% <0.00%> (-3.81%) ⬇️
dash-spv/src/client/event_handler.rs 93.88% <74.46%> (-2.07%) ⬇️
... and 2 more

... and 14 files with indirect coverage changes

View more details on Codecov