Skip to content

fix(rpc-json): disable key-wallet default features #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shumkov wants to merge 1 commit into from
+1 −1
Closed

fix(rpc-json): disable key-wallet default features #587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion key-wallet/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ readme = "README.md"
license = "CC0-1.0"

[features]
default = ["secp256k1/std", "bip39/std", "getrandom", "rand", "manager"]
default = ["secp256k1/std", "bip39/std", "getrandom", "rand"]
Copy link
Contributor

@coderabbitai coderabbitai bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

PR title scope appears inaccurate for this change.

The change is in key-wallet/Cargo.toml, but the title scope is fix(rpc-json). Please align scope/title with the actual crate changed (or split into focused PRs if both crates are intentionally changed).

As per coding guidelines, "Check whether the PR title prefix allowed in the pr-title.yml workflow accurately describes the changes."

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@key-wallet/Cargo.toml` at line 12, The PR title scope is incorrect for the
change in key-wallet/Cargo.toml; update the PR title to use the correct scope
(e.g., fix(key-wallet) or chore(key-wallet)) or split the changes into separate
PRs if other crates (like rpc-json) are also modified; ensure the chosen scope
matches the crate name "key-wallet" and that the title conforms to the
pr-title.yml allowed prefixes so the CI workflow recognizes it.

manager = ["dep:tokio"]
parallel-filters = ["manager", "dep:rayon"]
serde = ["dep:serde", "dep:serde_json", "dashcore_hashes/serde", "secp256k1/serde", "dashcore/serde"]
Expand Down
Loading