feat(sdk): add transport-free CXX bindings - #4416
Draft
PastaPastaPasta wants to merge 1 commit into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
PastaPastaPasta
force-pushed
the
feat/platform-cxx-bindings
branch
from
August 18, 2026 19:10
a1cca2d to
df4fdb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Dash Core's Platform GUI currently carries a private copy of its Rust/CXX bridge and pins individual Platform crates. This makes the embedding ABI, proof-verification logic, decoders, state-transition builders, and dependency closure owned by the consumer instead of Platform.
This stacked PR gives Platform ownership of that transport-free C++ embedding surface. It is based on #4389 and assumes #4388 and #4389 merge before this PR is retargeted to
v4.2-dev.What was done?
dash-platform-cxxworkspace package with the existingplatform_ffiABI for proof verification, DPP decoding, state-transition construction, quorum context, and callback-based wallet signing.After this lands, PastaPastaPasta/dash#67 will consume the installed archive and headers through Dash Core's
dependssystem and remove its private Rust/CXX implementation.How Has This Been Tested?
cargo test -p dash-platform-cxx --locked(31 tests)cargo clippy -p dash-platform-cxx --all-targets --locked -- -D warningscargo check --manifest-path packages/rs-platform-cxx/standalone/Cargo.toml --lockedrs-dapi-client, Hyper, Rustls, Tower, and Reqwestcargo machetecargo fmt --all -- --checkshellcheck packages/rs-platform-cxx/install.sh packages/rs-platform-cxx/test-cxx-link.shgit diff --checkBreaking Changes
None. The existing
platform_ffinamespace and bridge ABI from the downstream integration are preserved.Checklist:
For repository code-owners and collaborators only
This pull request was created by Codex.