refactor(rs-sdk): relocate DPNS network tests from src/ to tests/ by lklimek · Pull Request #3721 · dashpay/platform

lklimek · 2026-05-21T12:09:35Z

Summary

Relocates 5 network-integration tests for DPNS username helpers out of src/platform/dpns_usernames/{queries.rs,contested_queries.rs} (where they sat as #[cfg(test)] mod tests blocks) into a new packages/rs-sdk/tests/dpns_usernames.rs, and wires them through the existing test harness (Config::new().setup_api(namespace).await from tests/fetch/config.rs).

Split off from #3711 so the V0/V1 wire compatibility fix can land focused; this PR carries the pure test-organization cleanup.

What's wrong today (on v3.1-dev)

Wrong location. The DPNS network tests live in src/ even though they exercise only pub Sdk extension methods. They belong in tests/.
Hardcoded endpoint. Each of the 5 tests hardcodes https://52.12.176.90:1443 (a testnet HPMN, currently half-up — TCP listens, TLS dead). The endpoint is invisible to tests/.env / Config.
Wrong context provider for local devnets. Uses TrustedHttpContextProvider::new(Network::Testnet, ...) which fetches quorum info from a hardcoded testnet HTTP endpoint. Against a local devnet (e.g., dashmate + SDK_TEST_DATA=true), quorums don't match → Failed to find quorum: Quorum not found for type 106 ….
Brittle assertions. test_dpns_queries_from_docs asserts the testnet identity 5DbLwAxGBzUzo81VewMUwn4b5P4bpv9FNFybi25XB5Bk exists — fails on any reset chain.
Duplicate. tests/dpns_queries_test.rs repeats the same hardcoded endpoint pattern; another file to maintain.

What this PR does

Commit	Change
`09df598f3`	Step 1 (band-aid): introduce `src/.../test_address.rs` reading `DASH_SDK_PLATFORM_HOST/PORT/SSL` from `tests/.env` to unblock vector regen on local devnets
`9745211854`	Step 2 (proper move): delete `test_address.rs` + the two `#[cfg(test)] mod tests` blocks in `src/.../`. Delete `tests/dpns_queries_test.rs`. Create `tests/dpns_usernames.rs` with all 7 relocated tests sharing one `build_testnet_sdk()` helper. Re-mount `tests/fetch/config.rs` + `tests/fetch/generated_data.rs` via `#[path = "fetch/…"]`
`bd7117a1f7`	Wire `build_testnet_sdk()` through `Config::new().setup_api(namespace).await` — switches the SDK off `TrustedHttpContextProvider` onto the canonical `with_core(host, port, user, password)` path that resolves quorums via local Dash Core RPC
`75ed1d4203`	Loosen `test_dpns_queries_from_docs` → `test_dpns_queries_smoke`: all four existence assertions downgraded to `println!`. SDK calls still use `.expect(…)` so transport/proof errors panic loudly. Smoke guarantee is now "every fetch path returned `Ok`," not "the chain has alice."

Net effect: 5 tests moved out of src/, 1 file deleted (tests/dpns_queries_test.rs — folded in), 1 file created (tests/dpns_usernames.rs), 0 production-code changes. The methods under test were already pub on Sdk; no surface change.

The band-aid commit (09df598f3) is preserved in history rather than squashed — it's the smallest possible step that unblocked vector regen, useful as a bisect waypoint. If you prefer a single commit, squash on merge.

Test plan

cargo check -p dash-sdk --tests
cargo clippy -p dash-sdk --tests -- -D warnings
cargo fmt --all
On a local devnet (or SSH tunnel) with tests/.env populated:
```
cargo test -p dash-sdk --features generate-test-vectors dpns_usernames -- --include-ignored
```
Expect all 7 tests to pass (assuming devnet was built with SDK_TEST_DATA=true — see Seed DPNS contested-name prerequisites via SDK_TEST_DATA (extend create_sdk_test_data) #3720 for the prerequisite gap on test_contested_queries).

Out of scope

The create_sdk_test_data extension to seed DPNS contested-name prerequisites for tests/fetch/contested_resource.rs — tracked separately in Seed DPNS contested-name prerequisites via SDK_TEST_DATA (extend create_sdk_test_data) #3720.

_{Co-authored by Claudius the Magnificent AI Agent}

…ORM_* vars Five DPNS network tests (one in queries.rs, four in contested_queries.rs) hardcoded https://52.12.176.90:1443 (a testnet HPMN now half-up — TCP listens, TLS hangs), which silently bypassed packages/rs-sdk/tests/.env and made vector regeneration against a local devnet or SSH tunnel impossible. Introduce a shared #[cfg(test)] helper test_address::test_address_list() that loads tests/.env (best-effort) and builds an AddressList from DASH_SDK_PLATFORM_HOST / DASH_SDK_PLATFORM_PORT / DASH_SDK_PLATFORM_SSL — matching the existing Config schema used by tests/fetch/config.rs. The five hardcoded blocks now call this helper. Network/with_network(Testnet) is left untouched.

…and-aid endpoint helper Five #[cfg(test)] blocks in src/platform/dpns_usernames/{queries,contested_queries}.rs were really network-integration tests — they only used pub methods on Sdk (search, availability, resolve, contested-vote-state, etc.) and shipped their own band-aid test_address.rs helper to read DASH_SDK_PLATFORM_* env vars. They belong in tests/, where the existing fetch::Config harness already loads tests/.env via dotenvy/envy and exposes address_list() against the very same env vars. This commit: - Relocates all five #[ignore] network tests into a new tests/dpns_usernames.rs integration binary that re-mounts fetch::config + fetch::generated_data (#[path] sub-modules) so it can call Config::new().address_list() instead of parsing a hardcoded URL. - Folds the previously hardcoded tests/dpns_queries_test.rs (which also pinned https://52.12.176.90:1443) into the same file via the shared build_testnet_sdk() helper, deleting the old file. - Deletes src/platform/dpns_usernames/test_address.rs (the band-aid) and the five #[cfg(test)] mod tests blocks. No public-API change — the production helpers all stay where they were. Net: -test_address.rs, -2 inline mod tests, -dpns_queries_test.rs, +1 unified tests/dpns_usernames.rs, +consistent .env-driven endpoint config. Run with: cargo test -p dash-sdk --features generate-test-vectors -- --include-ignored

… local Core RPC quorum lookup build_testnet_sdk used TrustedHttpContextProvider::new(Network::Testnet, ...), which fetches quorum info from a hardcoded testnet HTTP endpoint. Three of the seven relocated DPNS tests (test_dpns_queries, test_dpns_queries_from_docs, test_dpns_search_variations) panicked with `Failed to find quorum: Quorum not found for type 106 and hash ...` when run against a local devnet or SSH tunnel — the testnet quorums simply don't match the local chain. Every other network test in `tests/fetch/*` solves this by going through `Config::setup_api(namespace)`, which wires the SDK with `SdkBuilder::with_core(host, port, user, password)`. Quorums are then resolved via the local Dash Core RPC the user is already running. This commit: - Replaces build_testnet_sdk with a one-line async helper that delegates to `Config::new().setup_api(namespace).await`. - Drops TrustedHttpContextProvider, build_testnet_context_provider, and the manual DPNS system-contract pre-load (Core RPC + standard fetch path is enough — no test depended on the pre-loaded contract for assertions). - Gives each test a unique namespace so per-test vector dump dirs don't collide when running with `--features generate-test-vectors`. The Network::Testnet hint is dropped along with the trusted context provider — `Config::setup_api` doesn't expose the network field, and the canonical `tests/fetch/*` suite operates without it just fine for proof verification via Core RPC.

…(chain-agnostic) The relocated test asserted testnet-specific data: that "alice" was registered, that it resolved to a hardcoded identity, that a prefix search returned at least one row. Against a local devnet or any reset chain those assertions fail — the chain simply doesn't have that data. Downgrade to a call-and-log smoke test (renamed test_dpns_queries_smoke): each SDK call still uses .expect("…should succeed") so transport or proof-verification failures still crash loudly, but the existence of specific on-chain rows is logged, not asserted. The test now exercises the DPNS query code paths against any network.

coderabbitai · 2026-05-21T12:09:42Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c8dfd65c-70cb-4059-8ed9-944b8d37bfcc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch refactor/rs-sdk-relocate-dpns-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

lklimek added 4 commits May 21, 2026 14:04

github-actions Bot added this to the v3.1.0 milestone May 21, 2026

Claudius-Maginificent mentioned this pull request May 21, 2026

fix(sdk): sdk emits incompatible getDocuments wire against pre-v3.1 networks (QueryContext approach) #3711

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(rs-sdk): relocate DPNS network tests from src/ to tests/#3721

refactor(rs-sdk): relocate DPNS network tests from src/ to tests/#3721
lklimek wants to merge 4 commits into
v3.1-devfrom
refactor/rs-sdk-relocate-dpns-tests

lklimek commented May 21, 2026

Uh oh!

coderabbitai Bot commented May 21, 2026

Review skipped

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

lklimek commented May 21, 2026

Summary

What's wrong today (on v3.1-dev)

What this PR does

Test plan

Out of scope

Uh oh!

coderabbitai Bot commented May 21, 2026

Review skipped

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant