Skip to content

bench(drive): add worst-case document count query fixture#3640

Merged
QuantumExplorer merged 1 commit into
feat/get-documents-v1-select-group-byfrom
codex/bench-expensive-count-queries
May 14, 2026
Merged

bench(drive): add worst-case document count query fixture#3640
QuantumExplorer merged 1 commit into
feat/get-documents-v1-select-group-byfrom
codex/bench-expensive-count-queries

Conversation

@QuantumExplorer
Copy link
Copy Markdown
Member

Summary

  • add a Criterion bench target for expensive document-count query shapes
  • build a cached GroveDB fixture through normal Drive contract/document insertion paths, defaulting to 2,000,000 rows
  • cover 100-branch In proof, 100 aggregate range-count fan-out, and compound In+range grouped no-proof/proof paths

Fixture knobs

  • DASH_PLATFORM_COUNT_BENCH_ROWS controls row count, default 2,000,000
  • DASH_PLATFORM_COUNT_BENCH_DB controls the cached fixture directory
  • DASH_PLATFORM_COUNT_BENCH_REBUILD=1 forces rebuild
  • DASH_PLATFORM_COUNT_BENCH_BATCH_SIZE controls rows per insert transaction, default 10,000

Validation

  • cargo check -p drive --benches
  • DASH_PLATFORM_COUNT_BENCH_ROWS=1000 cargo bench -p drive --bench document_count_worst_case -- --warm-up-time 0.1 --measurement-time 0.1

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 14, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2484b5b6-d093-4105-b33b-a58814c4f102

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/bench-expensive-count-queries

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thepastaclaw
Copy link
Copy Markdown
Collaborator

thepastaclaw commented May 14, 2026

Review Gate

Commit: 9ba6a0a4

  • Debounce: 206m ago (need 30m)

  • CI checks: build failure: PR title

  • CodeRabbit review: comment found

  • Off-peak hours: peak window (5am-11am PT) — currently 06:03 AM PT Thursday

  • Run review now (check to override)

Copy link
Copy Markdown
Member Author

@QuantumExplorer QuantumExplorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@QuantumExplorer QuantumExplorer merged commit 193808a into feat/get-documents-v1-select-group-by May 14, 2026
2 of 4 checks passed
@QuantumExplorer QuantumExplorer deleted the codex/bench-expensive-count-queries branch May 14, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants