Skip to content

chore: update rust-dashcore dependency to store TransactionContext in TransactionRecord#3406

Closed
dashinfraclaw wants to merge 1 commit intodashpay:v3.1-devfrom
dashinfraclaw:test-rust-dashcore-pr-582
Closed

chore: update rust-dashcore dependency to store TransactionContext in TransactionRecord#3406
dashinfraclaw wants to merge 1 commit intodashpay:v3.1-devfrom
dashinfraclaw:test-rust-dashcore-pr-582

Conversation

@dashinfraclaw
Copy link
Copy Markdown
Contributor

@dashinfraclaw dashinfraclaw commented Mar 26, 2026

Issue being fixed or feature implemented

Automated integration test for dashpay/rust-dashcore#582.

Validates that the changes in rust-dashcore PR #582 (refactor: store TransactionContext in TransactionRecord) compile and pass CI against this repository.

What was done?

Updated all dashcore/dashcore-rpc git dependencies in Cargo.toml files to point at the PR HEAD commit (5114330ae564858803d656efba84bb4adacb2a2e).

No functional code changes — dependency pointer update only.

How Has This Been Tested?

This PR exists to run the repository's existing CI suite against the updated dependency. CI results on this PR directly indicate compatibility.

Breaking Changes

None introduced by this PR. Any CI failures indicate potential breaking changes in the upstream rust-dashcore PR.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

Summary by CodeRabbit

  • Chores
    • Updated core library dependencies to the latest versions.

@github-actions github-actions bot added this to the v3.1.0 milestone Mar 26, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 26, 2026

Warning

Rate limit exceeded

@dashinfraclaw has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 18 minutes and 48 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 97a9450f-4fb5-481a-a876-5214fbf7995e

📥 Commits

Reviewing files that changed from the base of the PR and between 6ea48cd and ad5c132.

📒 Files selected for processing (1)
  • Cargo.toml
📝 Walkthrough

Walkthrough

Updated the git revision for six rust-dashcore workspace dependencies—dashcore, dash-spv, dash-spv-ffi, key-wallet, key-wallet-manager, and dashcore-rpc—from commit 8cbae416... to 5114330a... in the workspace dependencies configuration.

Changes

Cohort / File(s) Summary
Dependency revision updates
Cargo.toml
Updated [workspace.dependencies] git revision for all six rust-dashcore components (dashcore, dash-spv, dash-spv-ffi, key-wallet, key-wallet-manager, dashcore-rpc) from 8cbae416458565faac21d3452fbc6d80b324f6d3 to 5114330ae564858803d656efba84bb4adacb2a2e.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Hoppy times with fresh commits so new,
Six dashcore friends, all updated through!
From old to new, the revisions dance,
Dependencies bound in a git-powered trance,
Workspace harmony, a leap and a bound!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title references a specific upstream change (TransactionContext storage in TransactionRecord) that is the reason for the dependency update, directly capturing the intent of the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

… TransactionRecord

Update dashcore/dashcore-rpc git dependencies to 5114330ae564858803d656efba84bb4adacb2a2e
for integration testing of dashpay/rust-dashcore#582.
@dashinfraclaw dashinfraclaw force-pushed the test-rust-dashcore-pr-582 branch from 6ea48cd to ad5c132 Compare March 26, 2026 08:27
@shumkov
Copy link
Copy Markdown
Collaborator

shumkov commented Mar 26, 2026

Already working #3405

@shumkov shumkov closed this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants