chore: sync formating of rpc (exclude wallet rpc) code with Bitcoin Core#7129
chore: sync formating of rpc (exclude wallet rpc) code with Bitcoin Core#7129PastaPastaPasta merged 2 commits intodashpay:developfrom
Conversation
It's a follow-up for bitcoin#14726, bitcoin#25029 and other backports Formatting is synced up with state at Bitcoin Core v26 (most backports up to this version is done)
|
WalkthroughThis pull request performs a large-scale reformatting and documentation update across eleven RPC definition files. Changes include rewrapping help text, converting example types from CLI to RPC format, expanding and standardizing RPCResult schemas, and restructuring argument and result documentation blocks within RPCHelpMan definitions. Two functional enhancements are introduced: a new Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d46466f fmt: adjust formatting of rpc implementation for wallet to Bitcoin Core (Konstantin Akimov) Pull request description: ## Issue being fixed or feature implemented Doing backports for any RPC-related is struggle, because at some points formatting of files got different; due to missing changes from bitcoin#14726, bitcoin#25029, bitcoin#17809 and multiple other occasions. ## What was done? Manually sync formatting for wallet/rpc with Bitcoin Core v25.99 (commit bbbf89a) See also: #7129 These changes are split to 2 PR to reduce amount of conflicts and rebases in case of any backport are done due to huge diff size. Hint: use 'ignore whitespace' feature to review this PR. ## How Has This Been Tested? On top of this PR finally succeed to backport bitcoin#24118 for which I had lots of troubles to resolve conflicts. ## Breaking Changes N/A ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone ACKs for top commit: UdjinM6: utACK d46466f Tree-SHA512: 32debb41f769658e09d2aa19c9da77c9c4f4be6341a70ec9a2095ac2e37e29dc22a93d665e069aa146f78dca97e37e69cadfd058d74a5dcc64b898af487306a0
Issue being fixed or feature implemented
Doing backports for any RPC-related is struggle, because at some points formatting of files got different; due to missing changes from bitcoin#14726, bitcoin#25029, bitcoin#17809 and multiple other occasions.
What was done?
Manually sync formatting with rpc/ code (exclude wallet) Bitcoin Core v25.99 (commit bbbf89a)
See also: #7130
These changes are split to 2 PR to reduce amount of conflicts and rebases in case of any backport are done due to huge diff size.
Hint: use 'ignore whitespace' feature to review this PR.
How Has This Been Tested?
On top of this PR finally succeed to backport bitcoin#24118 for which I had lots of troubles to resolve conflicts.
Breaking Changes
N/A
Checklist: