Skip to content

chore: sync formating of rpc (exclude wallet rpc) code with Bitcoin Core#7129

Merged
PastaPastaPasta merged 2 commits intodashpay:developfrom
knst:bp-fmt-rpc-code
Feb 6, 2026
Merged

chore: sync formating of rpc (exclude wallet rpc) code with Bitcoin Core#7129
PastaPastaPasta merged 2 commits intodashpay:developfrom
knst:bp-fmt-rpc-code

Conversation

@knst
Copy link
Collaborator

@knst knst commented Feb 4, 2026

Issue being fixed or feature implemented

Doing backports for any RPC-related is struggle, because at some points formatting of files got different; due to missing changes from bitcoin#14726, bitcoin#25029, bitcoin#17809 and multiple other occasions.

What was done?

Manually sync formatting with rpc/ code (exclude wallet) Bitcoin Core v25.99 (commit bbbf89a)

See also: #7130
These changes are split to 2 PR to reduce amount of conflicts and rebases in case of any backport are done due to huge diff size.

Hint: use 'ignore whitespace' feature to review this PR.

How Has This Been Tested?

On top of this PR finally succeed to backport bitcoin#24118 for which I had lots of troubles to resolve conflicts.

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

knst added 2 commits February 5, 2026 01:40
It's a follow-up for bitcoin#14726, bitcoin#25029 and other backports

Formatting is synced up with state at Bitcoin Core v26 (most backports up to this version is done)
@knst knst added this to the 23.1 milestone Feb 4, 2026
@github-actions
Copy link

github-actions bot commented Feb 4, 2026

⚠️ Potential Merge Conflicts Detected

This PR has potential conflicts with the following open PRs:

Please coordinate with the authors of these PRs to avoid merge conflicts.

@coderabbitai
Copy link

coderabbitai bot commented Feb 4, 2026

Walkthrough

This pull request performs a large-scale reformatting and documentation update across eleven RPC definition files. Changes include rewrapping help text, converting example types from CLI to RPC format, expanding and standardizing RPCResult schemas, and restructuring argument and result documentation blocks within RPCHelpMan definitions. Two functional enhancements are introduced: a new echoipc RPC command in node.cpp that enables inter-process echo functionality, and an expanded getmemoryinfo RPC with additional memory statistics. All changes maintain backward compatibility with no modifications to function signatures or core logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately identifies the PR's main objective to sync RPC code formatting with Bitcoin Core, matching the primary change across multiple RPC files.
Description check ✅ Passed The description is clearly related to the changeset, explaining the motivation (formatting divergence causing backport difficulties), what was done (manual sync with Bitcoin Core), and testing approach.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 1a49e0f

PastaPastaPasta added a commit that referenced this pull request Feb 6, 2026
d46466f fmt: adjust formatting of rpc implementation for wallet to Bitcoin Core (Konstantin Akimov)

Pull request description:

  ## Issue being fixed or feature implemented
  Doing backports for any RPC-related is struggle, because at some points formatting of files got different; due to missing changes from bitcoin#14726, bitcoin#25029, bitcoin#17809 and multiple other occasions.

  ## What was done?
  Manually sync formatting for wallet/rpc with Bitcoin Core v25.99 (commit bbbf89a)

  See also: #7129
  These changes are split to 2 PR to reduce amount of conflicts and rebases in case of any backport are done due to huge diff size.

  Hint: use 'ignore whitespace' feature to review this PR.

  ## How Has This Been Tested?
  On top of this PR finally succeed to backport bitcoin#24118 for which I had lots of troubles to resolve conflicts.

  ## Breaking Changes
  N/A

  ## Checklist:
  - [x] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone

ACKs for top commit:
  UdjinM6:
    utACK d46466f

Tree-SHA512: 32debb41f769658e09d2aa19c9da77c9c4f4be6341a70ec9a2095ac2e37e29dc22a93d665e069aa146f78dca97e37e69cadfd058d74a5dcc64b898af487306a0
@PastaPastaPasta PastaPastaPasta merged commit 01555f6 into dashpay:develop Feb 6, 2026
41 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants