backport: Merge bitcoin/bitcoin#26733#7119
backport: Merge bitcoin/bitcoin#26733#7119cryptotura wants to merge 1 commit intodashpay:developfrom
Conversation
…tractfeefrom` parameter 057057a Add test for `sendmany` rpc that uses `subtractfeefrom` parameter (Yusuf Sahin HAMZA) Pull request description: This PR adds test that uses `sendmany` rpc to send **BTC** to multiple addresses using `subtractfeefrom` parameter, then checks receiver addresses balances to make sure fees are subtracted correctly. ACKs for top commit: achow101: ACK 057057a Tree-SHA512: 51167120d489f0ff7b8b9855424d07cb55a8965984f904643cddf45e7a08c350eaded498c350ec9c660edf72c2f128ec142347c9c79d5043d9f6cd481b15cd7e
✅ No Merge Conflicts DetectedThis PR currently has no conflicts with other open PRs. |
WalkthroughThe changes add two new test scenarios to the wallet functionality tests. The first scenario tests the sendmany operation with an explicit fee_rate parameter, where transaction fees are subtracted from multiple recipients. It creates addresses, sends DASH to them with fee subtraction enabled, advances the network, and verifies the received amounts reflect the fee deductions. The second scenario introduces a parallel test path that exercises explicit fee_rate specification alongside existing fee-rate tests, validating outcomes for sendtoaddress and sendmany operations. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
backporting