Skip to content

backport: Merge bitcoin/bitcoin#26733#7119

Open
cryptotura wants to merge 1 commit intodashpay:developfrom
CryptoTuraTeam:Feb
Open

backport: Merge bitcoin/bitcoin#26733#7119
cryptotura wants to merge 1 commit intodashpay:developfrom
CryptoTuraTeam:Feb

Conversation

@cryptotura
Copy link

backporting

…tractfeefrom` parameter

057057a Add test for `sendmany` rpc that uses `subtractfeefrom` parameter (Yusuf Sahin HAMZA)

Pull request description:

  This PR adds test that uses `sendmany` rpc to send **BTC** to multiple addresses using `subtractfeefrom` parameter, then checks receiver addresses balances to make sure fees are subtracted correctly.

ACKs for top commit:
  achow101:
    ACK 057057a

Tree-SHA512: 51167120d489f0ff7b8b9855424d07cb55a8965984f904643cddf45e7a08c350eaded498c350ec9c660edf72c2f128ec142347c9c79d5043d9f6cd481b15cd7e
@github-actions
Copy link

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

@coderabbitai
Copy link

coderabbitai bot commented Jan 29, 2026

Walkthrough

The changes add two new test scenarios to the wallet functionality tests. The first scenario tests the sendmany operation with an explicit fee_rate parameter, where transaction fees are subtracted from multiple recipients. It creates addresses, sends DASH to them with fee subtraction enabled, advances the network, and verifies the received amounts reflect the fee deductions. The second scenario introduces a parallel test path that exercises explicit fee_rate specification alongside existing fee-rate tests, validating outcomes for sendtoaddress and sendmany operations.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description 'backporting' is vague and generic, using a non-descriptive term that doesn't convey meaningful information about what is being backported or why. Expand the description to include what feature or test is being backported and its purpose, e.g., 'Backport Bitcoin PR #26733: Add test for sendmany with subtractfeefrom parameter to verify fee deduction from multiple recipients.'
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'backport: Merge bitcoin#26733' accurately describes the main change—backporting a specific Bitcoin commit into the Dash repository.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants