Skip to content

pkc%refac: bls_{chia,ietf}_*.json5 -> bls_*.json5 - #28

Merged
kwvg merged 9 commits into
dashpay:developfrom
kwvg:blscrp
Aug 17, 2026
Merged

pkc%refac: bls_{chia,ietf}_*.json5 -> bls_*.json5#28
kwvg merged 9 commits into
dashpay:developfrom
kwvg:blscrp

Conversation

@kwvg

@kwvg kwvg commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Motivation

base-sdk#19 merged bls_{chia,ietf} to unified bls feature, making the separation of test vectors unnecessary. In preparation for adding new test vectors, this pull request cleans house.

How Has This Been Tested?

cargo fmt --check
cargo test --features full
cargo clippy --features full --all-targets

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional tests
  • I have made corresponding changes to the documentation (note: N/A)
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@kwvg kwvg added this to the 0.1 milestone Aug 17, 2026
@kwvg kwvg self-assigned this Aug 17, 2026
@github-actions

Copy link
Copy Markdown

Note

This pull request has no conflicts! 🎊 🎉 🎊

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6a2b81a8-2c1b-4e14-8163-c8fe588fe1b4

📥 Commits

Reviewing files that changed from the base of the PR and between f6ef072 and b211ccc.

⛔ Files ignored due to path filters (24)
  • pkgs/pkc/corpus/bls_aggregate.json5 is excluded by !**/*.json5
  • pkgs/pkc/corpus/bls_chia_aggregate.json5 is excluded by !**/*.json5
  • pkgs/pkc/corpus/bls_chia_dh.json5 is excluded by !**/*.json5
  • pkgs/pkc/corpus/bls_chia_keygen.json5 is excluded by !**/*.json5
  • pkgs/pkc/corpus/bls_chia_llmq_100.json5 is excluded by !**/*.json5
  • pkgs/pkc/corpus/bls_chia_secure_aggregate.json5 is excluded by !**/*.json5
  • pkgs/pkc/corpus/bls_chia_ser_internals.json5 is excluded by !**/*.json5
  • pkgs/pkc/corpus/bls_chia_sign.json5 is excluded by !**/*.json5
  • pkgs/pkc/corpus/bls_chia_threshold.json5 is excluded by !**/*.json5
  • pkgs/pkc/corpus/bls_dh.json5 is excluded by !**/*.json5
  • pkgs/pkc/corpus/bls_hash.json5 is excluded by !**/*.json5
  • pkgs/pkc/corpus/bls_ietf_aggregate.json5 is excluded by !**/*.json5
  • pkgs/pkc/corpus/bls_ietf_dh.json5 is excluded by !**/*.json5
  • pkgs/pkc/corpus/bls_ietf_keygen.json5 is excluded by !**/*.json5
  • pkgs/pkc/corpus/bls_ietf_llmq_100.json5 is excluded by !**/*.json5
  • pkgs/pkc/corpus/bls_ietf_secure_aggregate.json5 is excluded by !**/*.json5
  • pkgs/pkc/corpus/bls_ietf_sign.json5 is excluded by !**/*.json5
  • pkgs/pkc/corpus/bls_ietf_threshold.json5 is excluded by !**/*.json5
  • pkgs/pkc/corpus/bls_keygen.json5 is excluded by !**/*.json5
  • pkgs/pkc/corpus/bls_llmq_100.json5 is excluded by !**/*.json5
  • pkgs/pkc/corpus/bls_secure_aggregate.json5 is excluded by !**/*.json5
  • pkgs/pkc/corpus/bls_serialize.json5 is excluded by !**/*.json5
  • pkgs/pkc/corpus/bls_sign.json5 is excluded by !**/*.json5
  • pkgs/pkc/corpus/bls_threshold.json5 is excluded by !**/*.json5
📒 Files selected for processing (11)
  • pkgs/dev/src/corpus.rs
  • pkgs/pkc/src/bls/chia_h2c.rs
  • pkgs/pkc/src/bls/public_ops.rs
  • pkgs/pkc/src/bls/scheme_chia.rs
  • pkgs/pkc/src/bls/scheme_ietf.rs
  • pkgs/pkc/src/bls/secret_ops.rs
  • pkgs/pkc/src/bls/share_ops.rs
  • pkgs/pkc/src/bls/sig_aggregate.rs
  • pkgs/pkc/src/bls/sig_basic.rs
  • pkgs/pkc/src/bls/sig_threshold.rs
  • pkgs/pkc/src/bls/tests.rs

Included review availability: Your plan includes up to 3 reviews per rolling hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

Changes

The PR adds Corpus::scope for cloned nested corpora. BLS tests now use shared serialization pairs and scheme-scoped corpora for Chia and IETF vectors.

BLS corpus and test migration

Layer / File(s) Summary
Corpus scoping and vector pairing
pkgs/dev/src/corpus.rs, pkgs/pkc/src/bls/tests.rs
Adds nested corpus scoping and shared Chia/IETF serialization-pair loading.
Shared serialization test vectors
pkgs/pkc/src/bls/public_ops.rs, pkgs/pkc/src/bls/scheme_chia.rs, pkgs/pkc/src/bls/sig_basic.rs
Updates public-key and signature serialization tests and removes obsolete fixture types.
Scheme-scoped BLS vector loading
pkgs/pkc/src/bls/chia_h2c.rs, pkgs/pkc/src/bls/scheme_ietf.rs, pkgs/pkc/src/bls/secret_ops.rs, pkgs/pkc/src/bls/share_ops.rs, pkgs/pkc/src/bls/sig_aggregate.rs, pkgs/pkc/src/bls/sig_threshold.rs
Replaces scheme-specific corpus paths with shared corpora scoped by chia or ietf.

Merge Risk: ⚪ Minimal · up to b211c

This PR consolidates BLS test-vector files and updates related references; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: renaming separate Chia and IETF BLS corpus files to unified names.
Description check ✅ Passed The description explains the unified BLS corpus refactor and lists validation commands related to the changes.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@kwvg
kwvg merged commit 0dc5fc0 into dashpay:develop Aug 17, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant