Align Helm Redis dependency with Chart.lock - #71
Merged
Conversation
helm dependency build fails the deep lane because Chart.yaml still pins Bitnami Redis at 0.0.7 while Chart.lock already records 23.1.1. Co-authored-by: Cursor <cursoragent@cursor.com>
The pre-commit sed matched every version: line, so it reset the Redis dependency back to 0.0.7 and produced an empty commit. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
8f0802d(#70merge) failed in Helm Deployment Smoke Test:Chart.lockis out of sync withChart.yaml.Chart.yamlstill listed Bitnami Redis as0.0.7(copied from the app/chart version).Chart.lockalready had the real chart,23.1.1.helm dependency buildsucceeds. Verified locally withhelm dependency build,helm lint, andhelm template(the steps that failed before kind).Test plan
helm dependency build helm/promgithub && helm lint helm/promgithubMade with Cursor