DO NOT MERGE: verify build-docker.yml PR trigger - #21978
Closed
kadykov wants to merge 5 commits into
Closed
Conversation
- Remove .ci/Dockerfile (2016-era Jenkins artefact, superseded) - .devcontainer/devcontainer.json: switch to pre-built GHCR image - .github/workflows/build-docker.yml: implement build→test→push workflow that builds from .devcontainer/Dockerfile, runs all Linux CI matrix configurations via .github/scripts/test-image.sh, and only pushes to GHCR if every build succeeds - .github/workflows/ci.yml: Linux jobs pull ghcr.io/darktable-org/ darktable-build:latest; permissions scoped to contents:read only - .github/scripts/test-image.sh: new helper script that runs all four Linux CI matrix configurations (GNU16 Release, LLVM22 Release, GNU16 Debug, GNU16 Release+tests) against a candidate Docker image; also callable locally for manual validation - .devcontainer/README.md: update CI environment section to describe the build→test→push workflow and correct the GHCR image update cadence - .gitignore: add install/ (created by test-image.sh during local runs)
…docker-build workflow, authenticate in GHCR for pulling images in CI workflow
…patch Add a pull_request trigger on .devcontainer/Dockerfile changes so that a Dockerfile-modifying PR gets a full build-test cycle before merge. The "Tag and push" step is guarded by `github.event_name != 'pull_request'` so nothing is ever published to GHCR during a PR run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test PR — verify
build-docker.ymlon pull requestsThis is a test-only draft PR. The only change is a non-functional comment line added to
Dockerfileto triggerbuild-docker.yml's newpull_requestpath filter.Expected behaviour:
Build, test and push CI Docker imagejob runsif: github.event_name != 'pull_request'), so GHCR is not modifiedThis verifies the CI refactoring in #21972. Results will be linked in that PR thread.
Do not merge — will be closed once the run is confirmed.