Do not exit darktable if mipmap buffer allocation fails - #21968
Open
victoryforce wants to merge 1 commit into
Open
Do not exit darktable if mipmap buffer allocation fails#21968victoryforce wants to merge 1 commit into
victoryforce wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We terminate the process (and kill unsaved work) if we cannot allocate memory for the mipmap buffer. This is a bad response to a (possibly temporary) memory shortage. And since we don't have
atexit(), it's actually not much different from crashing in terms of saving the user's work.The code that terminates the program on memory allocation failure is almost 15 years old, so you could say that it can wait a few more months. 🙂 OTOH, the fix is safe and I suggest adding it to 5.6.1.