lighttable: hide stale loading overlay for fallback mipmaps - #21953
Open
Arecsu wants to merge 1 commit into
Open
lighttable: hide stale loading overlay for fallback mipmaps#21953Arecsu wants to merge 1 commit into
Arecsu wants to merge 1 commit into
Conversation
TurboGit
added
bugfix
There was a problem hiding this comment.
Pull request overview
Adjusts lighttable thumbnail rendering so the “working…” overlay doesn’t remain visible when a smaller (fallback) mipmap is already being displayed during higher-resolution surface retries (e.g., full-preview 100% zoom transitions).
Changes:
- Updates busy-flag behavior to avoid showing the loading overlay when
DT_VIEW_SURFACE_SMALLERis returned but a usable surface already exists. - Adds explanatory comments describing the fallback-mipmap scenario and why retrying should continue without obscuring the image.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
@TurboGit copilot suggestion resolved. Will not incorporate the suggestion as I stated in that thread. This should be ready to merge (: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21812
A full-preview 100% zoom can temporarily render a smaller mipmap while the requested level loads. The thumbnail kept its busy flag set during those retries, leaving a stale
working...overlay visible. Keep the retry timer, but only show the busy message when no usable surface is available.Testing: