fix multi-image rating toast when clearing on 1-star#21432
Open
rtmongold wants to merge 1 commit into
Open
Conversation
TurboGit
added
bugfix
Member
|
Can't be for 5.6.1 as it introduces a new string. Or you may split in two PR, one without the "unrejecting" new string for 5.6.1 and the other for 5.8? |
Contributor
Author
|
@TurboGit I will split this into two PRs it was my initial plan anyways. |
When rating two or more images at once, the status message used the key pressed instead of the rating actually applied to the images. This was visible when toggling 1-star off (double-press 1): images were cleared to 0 stars but the toast still said "applying rating 1 to N images". Changed _ratings_apply() to use a shared _ratings_effective() helper for both the apply loop and a new _ratings_log_multi() toast helper. When all selected images receive the same effective rating, show that value. Rating behavior is unchanged; only on-screen wording is corrected.
rtmongold
force-pushed
the
fix_multi_image_toast
branch
from
3e8258b to
bb44dcd
Compare
Contributor
Author
|
@TurboGit ok got it split out, and will submit the other PR after this one goes through. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21416
When rating two or more images at once, the status message used the key pressed or internal upgrade/downgrade code instead of the rating actually applied to the images.
This was visible when toggling 1-star off (double-press 1): images were cleared to 0 stars but the toast still said "applying rating 1 to N images". The same problem affected upgrade/downgrade actions, which showed internal values like -1/-2, and un-rejecting images still said "rejecting".
Changed _ratings_apply() to use a shared _ratings_effective() helper for both the apply loop and a new _ratings_log_multi() toast helper. When all selected images receive the same effective rating, show that value; otherwise show a generic "applying ratings to N images" message (upgrade/downgrade).
Rating behavior is unchanged; only on-screen wording is corrected.