Skip to content

Fix agx crash on gui_init in AgX#21010

Open
masterpiga wants to merge 1 commit into
darktable-org:masterfrom
masterpiga:fix_agx_init
Open

Fix agx crash on gui_init in AgX#21010
masterpiga wants to merge 1 commit into
darktable-org:masterfrom
masterpiga:fix_agx_init

Conversation

@masterpiga
Copy link
Copy Markdown
Collaborator

@masterpiga masterpiga commented May 13, 2026

This caused darktable to crash occasionally when entering the darkroom.

Cause: During gui_init, dt_bauhaus_slider_set_soft_range() on the curve_contrast_around_pivot slider fires a signal chain → _update_curve_warnings → tries to dereference curve_toe_power/curve_shoulder_power which may not be assigned yet.
Fix: Added if(widget) guards before the two dt_bauhaus_widget_set_quad_paint() calls.

Co-authored with Claude.

@masterpiga masterpiga added bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes scope: image processing correcting pixels labels May 13, 2026
Copy link
Copy Markdown
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove submodules from commit. TIA.

Comment thread src/tests/integration
Comment thread src/external/lua-scripts
@TurboGit TurboGit added this to the 5.6 milestone May 13, 2026
@masterpiga
Copy link
Copy Markdown
Collaborator Author

Please remove submodules from commit. TIA.

Uups sorry, removed, thanks!

@masterpiga masterpiga requested a review from TurboGit May 13, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes scope: image processing correcting pixels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants