[AI] Unify ORT install + detection across Linux and Windows#20989
Open
andriiryzhkov wants to merge 2 commits into
Open
[AI] Unify ORT install + detection across Linux and Windows#20989andriiryzhkov wants to merge 2 commits into
andriiryzhkov wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the Windows install script and the in-app library detection up to par with the Linux paths. Fixes a Windows build warning in
dt_ai_ort_find_librariesfrom the previous platform-split scan, and synchronises behaviour so the same manifest fields and the same install/detect logic run on both platforms.preserve_layoutis currently only used by Linux AMD/ROCm wheels that ship auditwheel-bundled deps. Windows has no shipped use yet – this is preparatory work so a future package with nested DLLs (or detect-button testing) is handled without code changes.Changes
tools/ai/install-ort-gpu.ps1– parsepreserve_layoutfrom the manifest. A sharedCopy-MatchingLibshelper drives both main and runtime-bundle extraction. Verify step recurses (skipping*.libs/) in preserve-layout mode.src/ai/backend_onnx.c–dt_ai_ort_find_librariesuses one recursive scan path on both platforms. The Windows-only flat-only branch is removed, fixing the build warning and letting the preferences "detect" button find a nested ORT DLL the same way it does on Linux.