Remove useless CMake option controlling SSE2 codepath#20984
Open
victoryforce wants to merge 1 commit into
Open
Remove useless CMake option controlling SSE2 codepath#20984victoryforce wants to merge 1 commit into
victoryforce wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a CMake option
BUILD_SSE2_CODEPATHSwhich we use for adding"-msse2"and"-mfpmath=sse"compiler options. But this actually not needed as they are the default for the relevant architecture, x86-64.This made sense back when the x86-32 architecture was a thing. Not all such CPUs had support for new SIMD instruction sets. SSE appeared only in the Pentium III (in 1999), and SSE2 in the Pentium IV (in 2000). That is why SSE2 is not guaranteed to be on by default when compiling for 32-bit x86, so one may need to add
-msse2 -mfpmath=sse.But the fact is that it is hardly possible to compile recent versions of Darktable on old 32-bit systems. And it's not even about the program code itself, which will probably compile successfully. This is because such old systems (if they still exist in the wild) will not be able to provide the minimum versions of dependencies required by recent versions of Darktable. And that's not even mentioning the fact that such a build has long since ceased to make any sense.