Adds a context menu to the thumbtable to allow pinning any image in the 2nd darkroom window#20398
Open
masterpiga wants to merge 1 commit intodarktable-org:masterfrom
Open
Adds a context menu to the thumbtable to allow pinning any image in the 2nd darkroom window#20398masterpiga wants to merge 1 commit intodarktable-org:masterfrom
masterpiga wants to merge 1 commit intodarktable-org:masterfrom
Conversation
pinning any image in the 2nd darkroom window.
Member
|
@masterpiga : I'm not sure about this one because it introduces for the first time a contextual menu on the lighttable and why pin an image on the lighttable while the second window is actionable only on the darkroom. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to pin an image directly from the thumbtable, which makes it possible to show different images in the 2nd window while keeping the same image in the main window.
It adds a context menu to the images in the thumbtable, which for the moment contains only this one action.
It also fixes a bug that may cause darktable to crash when the 2nd window is toggled off and on very quickly, which may try to recreate the window while the previous one has not finished clearing up yet.
@TurboGit This is another follow up to #19963.