Skip to content

Comments

Remove protecting mutex in darktable.gui#20391

Merged
TurboGit merged 1 commit intodarktable-org:masterfrom
jenshannoschwalm:no_dtgui_mutex
Feb 24, 2026
Merged

Remove protecting mutex in darktable.gui#20391
TurboGit merged 1 commit intodarktable-org:masterfrom
jenshannoschwalm:no_dtgui_mutex

Conversation

@jenshannoschwalm
Copy link
Collaborator

  1. There is no reason for the protecting mutex as all gui data changing happens in main thread.
  2. We don't need to set darktable.gui to NULL as all pointers were set to NULL at the very start.

1. There is no reason for the protecting mutex as all gui data changing happens in main thread.
2. We don't need to set darktable.gui to NULL as all pointers were set to NULL at the very start.
@jenshannoschwalm jenshannoschwalm added this to the 5.6 milestone Feb 24, 2026
@jenshannoschwalm jenshannoschwalm added the scope: codebase making darktable source code easier to manage label Feb 24, 2026
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks!

@TurboGit TurboGit merged commit bb072ec into darktable-org:master Feb 24, 2026
5 checks passed
@jenshannoschwalm jenshannoschwalm deleted the no_dtgui_mutex branch February 25, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: codebase making darktable source code easier to manage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants