[RFC] - UI: rework module's UI (sliders, combobox, checkbox).

[TurboGit]

With the recent change to get more contrast on sliders it is now possible to refine them without loosing readability:

• Make the slider text font smaller.
• Make the slider thiner.
• Remove some padding.

Before	after

Also, with this PR the sections are standing out better.

[jenshannoschwalm]

For me this is really an improvement as it gives a lot of vertical room and has less "missing characters" for longer text.

Not so sure for people with visibility impairments though. Would we want a preference option for this like "dense module layout" ?

[TurboGit]

An option could be good indeed but there is also a CSS change which makes things harder. I'll see if we can improve this. And I have also noticed that the neutral point of the slider is not visible anymore. So this needs some more work.

[wpferguson]

I have old eyes and thus some issues especially with contrast. The new sliders look fine to me, even on my 4K laptop screen (vs my 32 inch monitor).

[TurboGit]

And with the neutral point indicator, on the top now as there is no space left below the slider:

Before	after

[zisoft]

My first thought was "great!". And it looks really great in the Colorbalance RBG module where ony sliders are involved.

But in other modules with mixed controls it looks unbalanced, all other controls have bigger text:

The checkbox above the exposure slider now looks huge. The proportions are no longer consistent.

And the handles are much smaller now as well, making it harder to hit them with the mouse.

[TurboGit]

Indeed, this needs more work to have consistent text size.

[TurboGit]

[TurboGit]

@zisoft : Let me know if you see some more issues. TIA.

[zisoft]

I use the circle for the slider handles, they are cut off at the bottom:

It looks more consistent now, but I think it is very small on a high resolution monitor.
And the checkbox seems too big in comparison.

[TurboGit]

@zisoft : The condensed mode can now be selected as an option. The circle should not be cut anymore and checkbox size should also be adjusted now.

[zisoft]

Yes, looks much better now:

The history is nearly unreadable small and the font baseline does not match the numbers:

[TurboGit]

@zisoft : Another iteration, fixes the history too small.

[zisoft]

This is how it looks now:

The font size of the history is better now, baseline alignment ist still off.

I think there may be many other places to tweak, see the text of the checkboxes in the color picker section which is barely readable.

[TurboGit]

The font size of the history is better now, baseline alignment ist still off.

Which OS? Font? I don't have this baseline alignment issue on my side.

[zisoft]

macOS, of course :)

No special font, just darktable default settings elegant-grey

Without the condensed setting everything looks perfect:

[jenshannoschwalm]

Here it looks almost good now with all themes.

1. geotagging still has an issue as

2. Couldn't see a message for "restart required" after changing preference of condensed mode

[TurboGit]

Couldn't see a message for "restart required" after changing preference of condensed mode

Indeed, I suspect a bug that is not due to this PR.

[TurboGit]

@jenshannoschwalm @zisoft : Last changes should fix all issues except maybe the size of the font in the entry geotaging & export for example. See #20395.

[zisoft]

More tests on macOS:

History and exposure module are looking great now, baseline offset is fixed:

Geotagging module right after darktable launch, no Lua in my dev environment:

After switching to darkroom and back to lighttable. The controls are now on the same line with the label, maybe that's the cause?

Couldn't see a message for "restart required" after changing preference of condensed mode

Indeed, I suspect a bug that is not due to this PR.

That's strange because I always get that message after changing the setting. No matter if I turn it on or off:

Besides the geotagging bug everything is perfect now!

[TurboGit]

Indeed without Lua, when I switch back to lighttable from darkroom I also have the size of entry being wrong.