add touchpad pinch zoom and two-finger pan#20356
Open
nevotgnab wants to merge 2 commits intodarktable-org:masterfrom
Open
add touchpad pinch zoom and two-finger pan#20356nevotgnab wants to merge 2 commits intodarktable-org:masterfrom
nevotgnab wants to merge 2 commits intodarktable-org:masterfrom
Conversation
nevotgnab
force-pushed
the
trackpad-darkroom-gestures
branch
from
a44f0e8 to
ac46abd
Compare
Author
|
touchpad pan currently conflicts with brush-size scroll. |
Author
|
TurboGit
added
priority: low
TurboGit
requested changes
Feb 22, 2026
Member
TurboGit
left a comment
TurboGit
left a comment
There was a problem hiding this comment.
Nice ! The panning is very slow on my side because it seems the sensitivity is low... So almost unusable. Any idea?
| { | ||
| if(!vm->current_view) | ||
| return FALSE; | ||
| if(vm->current_view->gesture_pan) |
Member
There was a problem hiding this comment.
Better to have a clear flow to me:
if
...
else if
...
else
...
| const double scale, | ||
| const int state) | ||
| { | ||
| if(!vm->current_view) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18048
Adds touchpad gesture support in Darkroom:
Implementation keeps existing layering:
Existing mouse wheel scroll path is unchanged, so non-touchpad scroll behavior remains intact.
[Update] Two-finger pan is also gated in darkroom states where scroll is used for mask/brush interactions (e.g. brush size), to preserve existing editing behavior.