Let the newer macOS build without trying to compile ghostty - #200
Merged
Conversation
The build step I just added to the newer macOS runner failed, and it was my mistake. One of the build phases compiles a small ghostty helper unless told not to, and the toolchain it uses cannot link on macOS 26. The test step already passed that flag through; the new build step did not. The failure gives you nothing to go on either, just "a script phase failed" with no error line, so the comment now says which flag and why.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Fixes the "Build app" step #199 added to the macos-26 leg. It failed on its first run, and that was my mistake, not a real macOS 26 problem.
A build phase runs
scripts/build-ghostty-cli-helper.sh, which compiles the Ghostty CLI helper with zig unlessPROGRAMA_SKIP_ZIG_BUILD=1(build-ghostty-cli-helper.sh:58). zig 0.15.2's MachO linker cannot resolve libSystem on macOS 26 — the same reason the matrix already setsskip_zig: trueon that leg. The pre-existing unit-test step passed that variable through; the new build step did not.Why it was hard to spot
The failure surfaces as:
No
error:line, no mention of zig, no indication which of several script phases failed. The only clue is anote:about an unrelated phase. The comment now records which variable and why, so the next person doesn't have to trace it back through the build phase.The good news from that run
#199 worked. On the macos-15 leg, for the first time:
macos-15 is fully green, smoke test included — so Programa is now verifiably building and launching on macOS 15, which this job had never once confirmed. The informational unit suite passed there too, meaning the quarantine from #198 holds.
Test plan
tests/test_ci_unit_test_runner_behavior.shpassesPROGRAMA_SKIP_ZIG_BUILDnow passed by both the build step and the unit-test step (2 occurrences), evaluating to1on macos-26 and0on macos-15workflow-guard-testspassesskipped(matrix.smokeis false there — deliberately untouched, see Make the compatibility check actually check compatibility #199)