Closed
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a mirror content provider to list and download DNPs at https://packages.dappnode.net/
One issue pending related signature verification of
signature.json:The signature creation process is:
List the release directory → Gets each file with its individual CID (not available in mirror right now)
Serialize the directory → Creates a string like:
avatar.png zdj7WnZ4Yn4ev7T8qSACAjqnErfqfQsCPsfrHuJNKcaAp7PkJ
dappnode_package.json zdj7WbUmsj617EgJRysWqPpzJxriYfmBxBo1uhAv3kqq6k3VJ
docker-compose.yml zdj7Wf2pYesVyvSbcTEwWVd8TFtTjv588FET9L7qgkP47kRkf
Sign the string → Creates ECDSA signature of that exact string
Verification Process (must match exactly):
When verifying, getReleaseSignatureStatus() does:
List files → Get individual CIDs from IPFS
Serialize with serializeIpfsDirectory() → Must produce identical string
Verify signature → ethers.verifyMessage(signedData, signature)
Individual file CIDs are required for signature verification.
Right now the mirror approach takes the package CID for all files as a placeholder. Signature will always be wrong