Skip to content

DAOS-18705 rebuild: set rebuild flag before creating rebuild_pool_tls#17941

Open
gnailzenh wants to merge 3 commits intomasterfrom
liang/b_agg_epc
Open

DAOS-18705 rebuild: set rebuild flag before creating rebuild_pool_tls#17941
gnailzenh wants to merge 3 commits intomasterfrom
liang/b_agg_epc

Conversation

@gnailzenh
Copy link
Copy Markdown
Contributor

@gnailzenh gnailzenh commented Apr 8, 2026 •
edited
Loading

  • set rebuild flag before creating rebuild_pool_tls, otherwise aggregation
    can progress to higher epoch than rebuild.
  • aggregation doesn't do full scan anymore after rebuild

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@gnailzenh
DAOS-18705 rebuild: stop refreshing aggregation epoch while rebuilding
d4ba532 
- stop refreshing aggregation epoch while rebuilding
- set rebuilding flag before setting rebuild fence

Signed-off-by: Liang Zhen <gnailzenh@gmail.com>
@gnailzenh gnailzenh requested review from a team as code owners April 8, 2026 04:56
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

Ticket title is 'DAOS 2.6.5: Interrupt rebuild with reintegration and interrupt with exclude with active IO'
Status is 'In Progress'
Labels: 'test_2.6.5,testp1'
https://daosio.atlassian.net/browse/DAOS-18705

@daosbuild3
Copy link
Copy Markdown
Collaborator

daosbuild3 commented Apr 8, 2026

Test stage Unit Test completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17941/1/testReport/

@wangshilong
refine codes
00dfa69 
Signed-off-by: Wang Shilong <shilong.wang@hpe.com>
@wangshilong wangshilong mentioned this pull request Apr 8, 2026
Closed
6 tasks
liuxuezhao
liuxuezhao previously approved these changes Apr 8, 2026
View reviewed changes
src/rebuild/rebuild_internal.h
/* local rebuild epoch mainly to constrain the VOS aggregation
* to make sure aggregation will not cross the epoch
/*
* XX: remove this.
Copy link
Copy Markdown
Contributor

@liuxuezhao liuxuezhao Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean replace by other method?

@gnailzenh
DAOS: code cleanup
171ecd4 
Signed-off-by: Liang Zhen <gnailzenh@gmail.com>
@gnailzenh gnailzenh changed the title DAOS-18705 rebuild: stop refreshing aggregation epoch while rebuilding DAOS-18705 rebuild: set rebuild flag before creating rebuild_pool_tls Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liuxuezhao liuxuezhao liuxuezhao left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gnailzenh @daosbuild3 @liuxuezhao @wangshilong