Add support for string literals in CSS list-style-type property#1507
Draft
Add support for string literals in CSS list-style-type property#1507
Conversation
Co-authored-by: daohoangson <239336+daohoangson@users.noreply.github.com>
Co-authored-by: daohoangson <239336+daohoangson@users.noreply.github.com>
…o-end Co-authored-by: daohoangson <239336+daohoangson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement this feature request @daohoangson/flutter_widget_from_html/issues/1504
Add support for string literals in CSS list-style-type property
Aug 31, 2025
|
Demo app73e33b9 APKs:
Web build has been deployed to https://demo-5sgtf4mtg-fwfh.vercel.app. Quick links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #1504
This PR implements support for CSS string literals as
list-style-typevalues, allowing developers to use custom text markers for HTML lists.What's Changed
Previously, the
list-style-typeproperty only supported predefined CSS keywords likedisc,circle,decimal, etc. This implementation adds support for quoted string literals as specified in the CSS specification.Examples
Implementation Details
getListMarkerText()to treat any unrecognized list-style-type value as a string literal"→")list-style-type: none)Technical Changes
getListMarkerText()incore_widget_factory.dartto return unrecognized types as-isbuildListMarker()to handle empty string literals by returningnull(no marker)_isPredefinedListStyleType()helper to distinguish between CSS keywords and string literalsTest Results
This change maintains full backward compatibility while enabling the flexible list styling requested in the original issue.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.