Fix #14539: false positive: constParameterPointer with type alias#8310
Open
ludviggunne wants to merge 2 commits intodanmar:mainfrom
Open
Fix #14539: false positive: constParameterPointer with type alias#8310ludviggunne wants to merge 2 commits intodanmar:mainfrom
ludviggunne wants to merge 2 commits intodanmar:mainfrom
Conversation
| fIsInitComma = (1ULL << 43), // Is this comma located inside some {..}. i.e: {1,2,3,4} | ||
| fIsInitBracket = (1ULL << 44), // Is this bracket used as a part of variable initialization i.e: int a{5}, b(2); | ||
| fIsAnonymous = (1ULL << 45), // Is this a token added for an unnamed member | ||
| fIsSimplifiedUsing = (1ULL << 46), |
Collaborator
There was a problem hiding this comment.
simplifyUsing() already sets fIsSimplifiedTypedef, see e.g. here:
Line 3417 in 13f7e53
So we should either use only the existing flag, or use the new one everywhere.
Collaborator
Author
There was a problem hiding this comment.
Hm, that's strange, then we shouldn't have a false positive in the first place. I'll look in to it. Thanks!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.