Partial fix for #14576: Missing attribute alignas (aligned_storage case)#8307
Open
ludviggunne wants to merge 2 commits intodanmar:mainfrom
Open
Partial fix for #14576: Missing attribute alignas (aligned_storage case)#8307ludviggunne wants to merge 2 commits intodanmar:mainfrom
ludviggunne wants to merge 2 commits intodanmar:mainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ludviggunne
force-pushed
the
14576-2
branch
2 times, most recently
from
a1da918 to
a8b3275
Compare
danmar
reviewed
Mar 11, 2026
|
|
||
| tok = tok->next(); | ||
| const Token *end = tok->link(); | ||
| tok = tok->next(); |
Owner
There was a problem hiding this comment.
this is redundant as far as I see and in theory tok will become null if "<" is the last token and then there will be a crash.
| if (std < Standards::CPP11 || std >= Standards::CPP23) | ||
| return; | ||
|
|
||
| for (Token *tok = list.front(); tok; tok = tok->next()) { |
Owner
There was a problem hiding this comment.
if tok becomes null in the loop body then yes there will be null pointer dereference when tok->next() is executed here. I am not sure if tok can become null but we do have some code like tok && .. that suggest that tok can become null..
ludviggunne
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.