added missing __GNUC__ define for selfcheck
#5324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
For ages I have been seeing warnings when running checking of out code locally which did not happen in the CI. Earlier I finally figured out that we were lacking the This would have been fixed with #4954 as well but I still want to postpone that for a little while. |
firewave
force-pushed
the
selfcheck-def-x
branch
from
7f75743 to
4005350
Compare
firewave
force-pushed
the
selfcheck-def-x
branch
from
d985e6f to
2186a2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing some code not to be enabled in the selfchecks leading to some missing warnings.