Fix deprecation warning from legacy node url module#299
Merged
danmactough merged 3 commits intomasterfrom Mar 21, 2026
Merged
Conversation
The legacy url.resolve() and url.parse() APIs trigger DEP0170 deprecation warnings in Node 20.11.1+ when they encounter invalid URLs like tag: URIs (e.g. tag:mefi.social,2024-01-26:objectId=20368395). Switch to the WHATWG URL constructor throughout utils.js. URL resolution now wraps new URL(pathUrl, baseUrl) in a try/catch so that non-resolvable URIs (tag:, urn:, and similar schemes) are returned unchanged rather than throwing or emitting a deprecation warning. Fixes #295. https://claude.ai/code/session_01V3aqinwFj3H6atH9MFX36r
The project's ESLint config has no ecmaVersion set, which defaults to ES5. Destructuring syntax is ES6+, so replace with a simple property access. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #295
Switching over to the WHATWG URL library resolves the deprecation warning (and future-proofs us for when the deprecated methods are removed).