feat: reset, remotes, signing, fixup, diff export, in-diff search, image previews, review feedback#6
Merged
Merged
Conversation
Follow-up to the ten-feature pass: adversarial-review fixes plus two rounds of UI feedback. Review findings: - Sidebar: every configured remote now renders even with no remote-tracking branches, so Add/Rename/Edit URL/Remove + a new per-remote Fetch are reachable; add_remote/set_remote_url reject ext::/fd:: URLs and option-like names; rename_remote surfaces libgit2 "problems" as a warning, not an error. - Commit signing parity: --cleanup=verbatim; amend keeps the original author; temp message file uses create_new (no symlink clobber). - Hard reset skips the safety snapshot when only untracked files are dirty. - gitignore quick-add escapes glob metacharacters in literal paths. - In-diff search tags matches with their staging side so a jump lands on the copy that holds the match; Esc closes from any focused child of the bar. - ResetDialog moves focus into the modal on open. - Review feedback exports the union of pool + orphaned noted files; notes on deletion-only blocks anchor old-side; image preview refetches on diff churn. Image previews: - Fix binary detection in diff collect(): is_binary() is unset until the print pass runs, so binary files came back as empty diffs. Flag binary on the 'B' marker line instead. - Before/After (or single) image previews in Local Changes, Review, commit detail, and the File view Content / History / Compare tabs. Ignore menu: - "Add ignore pattern..." dialog for arbitrary globs; the three ignore actions now sit under an "Ignore >" submenu (ContextMenu gained submenu support). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ten developer-requested git-client features plus the fixes from a multi-lens adversarial review and two rounds of UI feedback. Build gates pass throughout (cargo test, cargo clippy -D warnings, tsc --noEmit, vitest).
Features
commit.gpgSign=true, commits route through the user'sgit(real GPG/SSH signature) instead of silently producing unsigned commits.Ignore >submenu.Quality
ext::/fd::URL guard, gitignore glob escaping, signing parity, review-export data loss, image binary detection, in-diff search side-jump, dialog focus).Still deliberately open
Line-level staging, rebase
edit, multi-repo-tab architecture, full-history/-Gcontent search, and a GitHub/GitLab PR surface — tracked indocs/improvements.md.🤖 Generated with Claude Code